fix: emit NOASSERTION for copyright text to fix SPDX 2.2 validation failure #3495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Fearkin <[email protected]>
Signed-off-by: Christopher Phillips <[email protected]>
Signed-off-by: Christopher Phillips <[email protected]>
|
I plan to add a test that would have caught this on |
Signed-off-by: Will Murphy <[email protected]>
Signed-off-by: Will Murphy <[email protected]>
Signed-off-by: Will Murphy <[email protected]>
|
Tests added and snapshots updated. This is ready for re-review. |
willmurphyscode
changed the title
wagoodman
reviewed
Dec 4, 2024
There was a problem hiding this comment.
nit: just a heads up for the future... there are two things that can be updated:
https://github.com/anchore/syft/blob/main/syft/format/spdxjson/encoder_test.go#L20-L21
I think the image did not need to be updated (and rarely needs to be), only the snapshots needed to be updated.
wagoodman
approved these changes
Dec 4, 2024
spiffcs
added a commit
that referenced
this pull request
Dec 9, 2024
…syft into spdx-absolute-path-file * 'spdx-absolute-path-file' of https://github.com/anchore/syft: chore(deps): update CPE dictionary index (#3507) chore(deps): update tools to latest versions (#3506) chore(deps): bump github.com/magiconair/properties from 1.8.7 to 1.8.9 (#3508) chore(deps): bump actions/cache from 4.1.2 to 4.2.0 (#3503) Add relationships for rust audit binary packages (#3500) fix order of rust dependencies and support git sources in Cargo.lock dependencies (#3502) chore(deps): update tools to latest versions (#3501) chore(deps): bump golang.org/x/net from 0.31.0 to 0.32.0 (#3499) chore: add and document target for updating unit snapshots (#3498) fix: emit NOASSERTION for copyright text to fix SPDX 2.2 validation failure (#3495)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
@Fearkin I could not push to your branch since it was on
mainof your fork. I've pushed a commit, checked out a local branch, and kept your commits so you still get the contribution credit.FileCopyrightTextto SPDX formatsFixes #3346
Type of change
Checklist: