3122 valid license url characters #3449
Merged
+60
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Christopher Phillips <[email protected]>
Signed-off-by: Christopher Phillips <[email protected]>
wagoodman
reviewed
Nov 18, 2024
wagoodman
reviewed
Nov 18, 2024
| cleanedURL = strings.TrimSpace(cleanedURL) | ||
|
|
||
| // Step 3: Validate the cleaned URL | ||
| _, err := url.ParseRequestURI(cleanedURL) |
There was a problem hiding this comment.
should we leave these in the core model but then filter them when encoding sbom specs that have specific requirements? That is, should we move this to the cyclonedx encoder? We could check for any similar requirement for SPDX and do the same.
There was a problem hiding this comment.
I think it's best to clean it as early as possible in the process and get our own model's URL inline with the RFC 3987 IRI-reference
Signed-off-by: Christopher Phillips <[email protected]>
wagoodman
approved these changes
Nov 19, 2024
Signed-off-by: Christopher Phillips <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the license constructors to strip unwanted characters from URLs in license metadata and make sure all URLs conform to RFC 3987 IRI-reference.
Fix Validation
go run cmd/syft/main.go --output cyclonedx-json=file.json --verboseThe URL now listed for the
UserAgentUtilsshould no longer have special characters in it as listed in the issue.Type of change
Checklist: