Omit empty packages #312
Merged
Omit empty packages #312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dan Luhring <[email protected]>
alfredodeza
suggested changes
Jan 22, 2021
| @@ -172,6 +173,12 @@ func parsePackageJSON(_ string, reader io.Reader) ([]pkg.Package, error) { | |||
| return nil, fmt.Errorf("failed to parse package.json file: %w", err) | |||
| } | |||
|
|
|||
| if !p.hasMinimumRequiredValues() { | |||
| log.Debug("encountered package.json file without the minimum number of field values required for" + | |||
There was a problem hiding this comment.
which fields? (I know, but a user will probably not)
| } | ||
|
|
||
| if len(actual) != 0 { | ||
| t.Errorf("no packages should've been returned") |
There was a problem hiding this comment.
Suggested change
| t.Errorf("no packages should've been returned") | |
| t.Errorf("no packages should've been returned, but got %d", len(actual)) |
| @@ -1,2 +1,5 @@ | |||
| FROM alpine:latest | |||
| RUN apk add tzdata vim alpine-sdk | |||
| FROM alpine@sha256:d9a7354e3845ea8466bb00b22224d9116b183e594527fb5b6c3d30bc01a20378 | |||
Signed-off-by: Dan Luhring <[email protected]>
luhring
force-pushed
the
omit-empty-packages
branch
from
e5bfbaa to
9ec3ad5
Compare
Signed-off-by: Dan Luhring <[email protected]>
Signed-off-by: Dan Luhring <[email protected]>
alfredodeza
approved these changes
Jan 22, 2021
GijsCalis
pushed a commit
to GijsCalis/syft
that referenced
this pull request
Feb 19, 2024
Omit empty packages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #311
This PR changes the parsing of
package.jsonsuch that files that don't include the minimally required fields (currentlynameandversion) will not be surfaced as packages. ADEBUGlevel message is logged in this case.