Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename file.Location.VirtualPath to AccessPath #2288

Merged
merged 1 commit into from
Nov 9, 2023
Merged

Conversation

wagoodman
Copy link
Contributor

Closes #1835

Note: must be merged after #2287

@wagoodman wagoodman linked an issue Nov 3, 2023 that may be closed by this pull request
@wagoodman wagoodman marked this pull request as ready for review November 8, 2023 23:05
@wagoodman wagoodman requested a review from a team November 8, 2023 23:05
Base automatically changed from add-accessPath-to-json to main November 8, 2023 23:05
@wagoodman wagoodman force-pushed the rename-virtual-path branch from c2369e8 to e898cf4 Compare November 8, 2023 23:06
@spiffcs
Copy link
Contributor

spiffcs commented Nov 9, 2023

#2287 merged and this refactor does not break any current tests - LGTM

@wagoodman wagoodman merged commit 3f13d20 into main Nov 9, 2023
10 checks passed
@wagoodman wagoodman deleted the rename-virtual-path branch November 9, 2023 17:30
GijsCalis pushed a commit to GijsCalis/syft that referenced this pull request Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename Location virtualPath to accessPath
2 participants