Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add conaninfo.txt parser to detect conan packages in docker images #2234

Merged
merged 2 commits into from
Oct 23, 2023

Conversation

Pro
Copy link
Contributor

@Pro Pro commented Oct 16, 2023

Currently, syft only supports parsing conanfile.txt or conan.lock files.

If a conan package is installed inside a docker container (e.g., in $HOME/.conan/data), then this is not detected by syft.

With this MR the corresponding functionality is added.

I.e., every installed conan package contains a conaninfo.txt.

We can use this in the globbing to detect the packages and then parse the additional conan package information.

@Pro Pro force-pushed the feat-add-conan-to-docker branch from 833e8d0 to fe26eed Compare October 16, 2023 18:10
@Pro Pro force-pushed the feat-add-conan-to-docker branch from fe26eed to 670fd85 Compare October 17, 2023 08:11
@wagoodman wagoodman self-assigned this Oct 18, 2023
Copy link
Contributor

@wagoodman wagoodman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work @Pro 🙌

@wagoodman wagoodman merged commit 234ce4e into anchore:main Oct 23, 2023
9 checks passed
@Pro Pro deleted the feat-add-conan-to-docker branch October 23, 2023 22:19
@spiffcs spiffcs added the enhancement New feature or request label Oct 31, 2023
GijsCalis pushed a commit to GijsCalis/syft that referenced this pull request Feb 19, 2024
…ges (anchore#2234)

* feat: add conaninfo.txt parser to detect conan packages in docker images

Signed-off-by: Stefan Profanter <[email protected]>

* fix: add NewConanInfoCataloger as a separate cataloger

Signed-off-by: Stefan Profanter <[email protected]>

---------

Signed-off-by: Stefan Profanter <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants