source: plumb sym link base through to syft CLI #1830
Conversation
Continuing the work of b81c980, change the behavior of the syft command: the root for symbol link resolution of directory scans is now the directory root, not "/". Do this pedantically, by separating the directory root to the scanned from the directory sym link base. As of this commit, these two values will always be the same, but this strategy leaves the door open for them to be different someday, if that would ever be useful. Also remove some unused functions and consolidate down to just the NewFromDirectoryBaseWithName() function. Signed-off-by: Jeff Squyres <[email protected]>
|
Looks like some of those "unused" functions I removed are used by tests. I'll investigate... |
|
Hi @jsquyres and thanks for the contribution here -- we have a bit of a different change that does this in PR #1867. It should be noted the referenced PR has a prerequisite of some other changes and we're looking at getting these done hopefully in a week-ish timeframe. That said, I'm going to close this PR due to the overlap. Please let me know if I've misunderstood something and would be happy to reopen it! |
|
@kzantow Sorry for my long silence on this -- I got distracted by vacation, holidays, and other shiny objects. If #1867 implements effectively the same kind of functionality as I did in this PR, we can certainly close this PR. I'd just like the functionality, regardless of whether it's my PR or someone else's. 😄 |
|
Thanks @jsquyres! I'm going to close this as noted -- we're making progress |
Continuing the work of b81c980, change the behavior of the syft command: the root for symbol link resolution of directory scans is now the directory root, not "/".
Do this pedantically, by separating the directory root to the scanned from the directory sym link base. As of this commit, these two values will always be the same, but this strategy leaves the door open for them to be different someday, if that would ever be useful.
Also remove some unused functions and consolidate down to just the NewFromDirectoryBaseWithName() function.
Refs #1485, #1359