Update tests to not fail on Mac M1's #1730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes anchore#1673 Signed-off-by: Shane Dell <[email protected]>
wagoodman
approved these changes
Apr 12, 2023
wagoodman
changed the title
|
@wagoodman One thing to note is that on M1's if images have not been built to support arm it will throw an error. For example: go run cmd/syft/main.go python:3.8works fine however go run cmd/syft/main.go registry1.dso.mil/ironbank/anchore/enterprise/enterprise:4.5.0Will cause an error such as: ⠧ Pulling image
2023/04/12 11:16:04 error during command execution: 1 error occurred:
* failed to construct source from user input "registry1.dso.mil/ironbank/anchore/enterprise/enterprise:4.5.0": could not fetch image "registry1.dso.mil/ironbank/anchore/enterprise/enterprise:4.5.0": unable to use DockerDaemon source: image has unexpected architecture "amd64", which differs from the user specified architecture "arm64"
exit status 1Not sure if this is a huge deal or not but wasn't sure if its something that would need to be documented. Would this need added any where to let users know that some images will not be supported yet on Apple Silicon and other arm devices? |
spiffcs
added a commit
that referenced
this pull request
Apr 17, 2023
* main: (35 commits) Fix kernel cataloger test fixtures (#1742) feat: Support scanning license files in golang packages over the network (#1630) Add package-to-file location evidence relationships (#1698) Add Linux Kernel cataloger (#1694) Add annotations for evidence on package locations (#1723) add format make target (#1733) Update tests to not fail on Mac M1's. (#1730) chore(deps): update bootstrap tools to latest versions (#1728) Add support for nar files. (#1727) add highlevel details about catalogers (#1726) chore(deps): bump golang.org/x/net from 0.8.0 to 0.9.0 (#1722) chore(deps): update stereoscope to e95d60a265e384df29b7a139f5c5402d6ad72e06 (#1721) feat: gradle lockfile support (#1719) chore(deps): bump github.com/docker/docker (#1715) chore(deps): bump golang.org/x/mod from 0.9.0 to 0.10.0 (#1713) chore(deps): bump golang.org/x/term from 0.6.0 to 0.7.0 (#1714) chore(deps): bump github.com/spf13/cobra from 1.6.1 to 1.7.0 (#1716) chore(deps): bump peter-evans/create-pull-request from 4 to 5 (#1712) chore: update tools-golang to v0.5.0 (#1717) Add Nix cataloger (#1696) ... Signed-off-by: Christopher Phillips <[email protected]>
GijsCalis
pushed a commit
to GijsCalis/syft
that referenced
this pull request
Feb 19, 2024
Closes anchore#1673 Signed-off-by: Shane Dell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update tests to not fail on Mac M1's.
Closes #1673