fix: more python matching support #1667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Keith Zantow <[email protected]>
spiffcs
reviewed
Mar 13, 2023
There was a problem hiding this comment.
Looks like there is a quality gate failure:
Summary:
Baseline Packages: 175
New Packages: 176
Baseline Packages Matched: 88.00 % (154/175 packages)
Baseline Metadata Matched: 0.57 % (1/175 metadata)
Quality Gate: FAILED (requires exact name & version match)
And same thing appears for AC Tests:
Summary:
Baseline Packages: 175
New Packages: 176
Baseline Packages Matched: 88.00 % (154/175 packages)
Baseline Metadata Matched: 0.57 % (1/175 metadata)
Quality Gate: FAILED (requires exact name & version match)
Also added some comments to help me understand the PR better. Sorry for the confusion on reviewing this one, just wanted to make sure I'm caught up and fully understand the updates. It looks like the main change is to escape the dots so they don't match on any and then truncate as illustrated in the linked comment. That looks good! Just had small questions about the other changes.
Signed-off-by: Keith Zantow <[email protected]>
This was referenced Mar 14, 2023
Closed
spiffcs
added a commit
to deitch/syft
that referenced
this pull request
Mar 21, 2023
* main: (47 commits) Deprecate config.yaml as valid config source; Add unit regression for correct config paths (anchore#1640) chore: Update syft bootstrap tools to latest versions. (anchore#1682) Update documentation: (anchore#1680) chore: Update Stereoscope to 7928713c391e20abaede6a029f4ce37b628a4c8b (anchore#1681) fix: reduce logging for bad dpkg lines (anchore#1675) fix ruby classifier (anchore#1678) feat: add shared dir for easier cleanup (anchore#1676) chore(deps): bump github.com/google/go-containerregistry (anchore#1672) chore(deps): bump actions/setup-go from 3 to 4 (anchore#1671) fix: move defer after error to protect panic case (anchore#1670) feat: add argocd, helm, kustomize and kubectl binary classifiers (anchore#1663) defer closing file (anchore#1668) fix: remove author contributing to javascript CPEs (anchore#1669) fix: more python matching support (anchore#1667) Update syft bootstrap tools to latest versions. (anchore#1666) feat: add ruby classifier (anchore#1665) Update syft bootstrap tools to latest versions. (anchore#1658) fix: improved Python binary detection (anchore#1648) fix: suppress some known incorrect vendor candidates for npm CPEs (anchore#1659) fix: sanitize SPDX LicenseRefs (anchore#1657) ... Signed-off-by: Christopher Phillips <[email protected]>
This was referenced Apr 3, 2023
GijsCalis
pushed a commit
to GijsCalis/syft
that referenced
this pull request
Feb 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@noqcks pointed out a few more python matching cases in the comment here. This PR corrects an issue where
fileNameTemplateVersionMatcherwas causing versions with.to be treated as a regex dot, which matched any character. Additionally, it adds support for libpython named with a letter following the version number, e.g.libpython3.4m.so.1.0.