Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port php cataloger to new generic cataloger pattern #1315

Merged
merged 1 commit into from
Nov 3, 2022

Conversation

wagoodman
Copy link
Contributor

Follow up to #1281 , porting the php cataloger to the new generic.Cataloger.

@wagoodman wagoodman requested a review from a team November 3, 2022 13:55
@wagoodman wagoodman enabled auto-merge (squash) November 3, 2022 13:55
@github-actions
Copy link

github-actions bot commented Nov 3, 2022

Benchmark Test Results

Benchmark results from the latest changes vs base branch
name                                                       old time/op    new time/op    delta
ImagePackageCatalogers/alpmdb-cataloger-2                    15.8ms ±28%    11.2ms ± 1%  -29.05%  (p=0.016 n=5+4)
ImagePackageCatalogers/ruby-gemspec-cataloger-2              1.63ms ± 2%    1.29ms ± 1%  -20.75%  (p=0.008 n=5+5)
ImagePackageCatalogers/python-package-cataloger-2            4.19ms ± 3%    3.22ms ± 1%  -23.27%  (p=0.008 n=5+5)
ImagePackageCatalogers/php-composer-installed-cataloger-2    1.34ms ± 4%    1.06ms ± 1%  -21.07%  (p=0.008 n=5+5)
ImagePackageCatalogers/javascript-package-cataloger-2         965µs ± 3%     740µs ± 0%  -23.29%  (p=0.008 n=5+5)
ImagePackageCatalogers/node-binary-cataloger-2               8.15µs ± 1%    6.57µs ± 1%  -19.43%  (p=0.008 n=5+5)
ImagePackageCatalogers/dpkgdb-cataloger-2                    1.09ms ± 4%    0.86ms ± 1%  -20.52%  (p=0.008 n=5+5)
ImagePackageCatalogers/rpm-db-cataloger-2                    1.58ms ± 3%    1.26ms ± 2%  -20.40%  (p=0.008 n=5+5)
ImagePackageCatalogers/java-cataloger-2                      18.0ms ± 4%    14.4ms ± 1%  -20.10%  (p=0.008 n=5+5)
ImagePackageCatalogers/apkdb-cataloger-2                     1.58ms ± 2%    1.24ms ± 2%  -21.59%  (p=0.008 n=5+5)
ImagePackageCatalogers/go-module-binary-cataloger-2          8.17µs ± 1%    6.60µs ± 1%  -19.20%  (p=0.008 n=5+5)
ImagePackageCatalogers/dotnet-deps-cataloger-2               1.67ms ± 1%    1.35ms ± 1%  -19.20%  (p=0.008 n=5+5)
ImagePackageCatalogers/portage-cataloger-2                    894µs ± 5%     701µs ± 1%  -21.65%  (p=0.008 n=5+5)

name                                                       old alloc/op   new alloc/op   delta
ImagePackageCatalogers/alpmdb-cataloger-2                    5.27MB ± 0%    5.27MB ± 0%     ~     (p=0.548 n=5+5)
ImagePackageCatalogers/ruby-gemspec-cataloger-2               204kB ± 0%     204kB ± 0%     ~     (p=0.151 n=5+5)
ImagePackageCatalogers/python-package-cataloger-2             960kB ± 0%     960kB ± 0%     ~     (p=0.095 n=5+5)
ImagePackageCatalogers/php-composer-installed-cataloger-2     216kB ± 0%     219kB ± 0%   +1.00%  (p=0.008 n=5+5)
ImagePackageCatalogers/javascript-package-cataloger-2         159kB ± 0%     159kB ± 0%     ~     (p=0.889 n=5+5)
ImagePackageCatalogers/node-binary-cataloger-2               1.12kB ± 0%    1.12kB ± 0%     ~     (all equal)
ImagePackageCatalogers/dpkgdb-cataloger-2                     200kB ± 0%     200kB ± 0%     ~     (p=0.421 n=5+5)
ImagePackageCatalogers/rpm-db-cataloger-2                     302kB ± 0%     302kB ± 0%     ~     (p=0.095 n=5+5)
ImagePackageCatalogers/java-cataloger-2                      3.45MB ± 0%    3.45MB ± 0%     ~     (p=0.310 n=5+5)
ImagePackageCatalogers/apkdb-cataloger-2                     1.25MB ± 0%    1.25MB ± 0%   -0.08%  (p=0.032 n=5+5)
ImagePackageCatalogers/go-module-binary-cataloger-2          1.12kB ± 0%    1.12kB ± 0%     ~     (all equal)
ImagePackageCatalogers/dotnet-deps-cataloger-2                379kB ± 0%     378kB ± 0%   -0.21%  (p=0.008 n=5+5)
ImagePackageCatalogers/portage-cataloger-2                    138kB ± 0%     138kB ± 0%     ~     (p=0.841 n=5+5)

name                                                       old allocs/op  new allocs/op  delta
ImagePackageCatalogers/alpmdb-cataloger-2                     85.7k ± 0%     85.7k ± 0%     ~     (p=1.000 n=4+5)
ImagePackageCatalogers/ruby-gemspec-cataloger-2               4.24k ± 0%     4.24k ± 0%     ~     (p=0.444 n=5+5)
ImagePackageCatalogers/python-package-cataloger-2             16.5k ± 0%     16.5k ± 0%     ~     (p=0.841 n=5+5)
ImagePackageCatalogers/php-composer-installed-cataloger-2     5.51k ± 0%     5.56k ± 0%   +1.03%  (p=0.008 n=5+5)
ImagePackageCatalogers/javascript-package-cataloger-2         3.34k ± 0%     3.34k ± 0%     ~     (all equal)
ImagePackageCatalogers/node-binary-cataloger-2                 38.0 ± 0%      38.0 ± 0%     ~     (all equal)
ImagePackageCatalogers/dpkgdb-cataloger-2                     4.51k ± 0%     4.51k ± 0%     ~     (all equal)
ImagePackageCatalogers/rpm-db-cataloger-2                     8.11k ± 0%     8.11k ± 0%     ~     (all equal)
ImagePackageCatalogers/java-cataloger-2                       57.5k ± 0%     57.5k ± 0%     ~     (p=0.524 n=5+5)
ImagePackageCatalogers/apkdb-cataloger-2                      5.39k ± 0%     5.39k ± 0%     ~     (p=0.238 n=5+4)
ImagePackageCatalogers/go-module-binary-cataloger-2            38.0 ± 0%      38.0 ± 0%     ~     (all equal)
ImagePackageCatalogers/dotnet-deps-cataloger-2                7.33k ± 0%     7.33k ± 0%     ~     (all equal)
ImagePackageCatalogers/portage-cataloger-2                    3.58k ± 0%     3.58k ± 0%     ~     (p=0.556 n=4+5)

@wagoodman wagoodman merged commit 891f2c5 into main Nov 3, 2022
@wagoodman wagoodman deleted the update-php-generic-cataloger branch November 3, 2022 17:00
GijsCalis pushed a commit to GijsCalis/syft that referenced this pull request Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants