Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add s3 credentials to release #1309

Merged
merged 1 commit into from
Nov 2, 2022
Merged

Add s3 credentials to release #1309

merged 1 commit into from
Nov 2, 2022

Conversation

wagoodman
Copy link
Contributor

@wagoodman wagoodman commented Nov 2, 2022

Fixes regression introduced in #1280 , now the release workflow should be able to upload to S3 to update the version file.

Signed-off-by: Alex Goodman <[email protected]>
@wagoodman wagoodman requested a review from a team November 2, 2022 15:21
@wagoodman wagoodman enabled auto-merge (squash) November 2, 2022 15:22
@github-actions
Copy link

github-actions bot commented Nov 2, 2022

Benchmark Test Results

Benchmark results from the latest changes vs base branch
name                                                       old time/op    new time/op    delta
ImagePackageCatalogers/alpmdb-cataloger-2                    11.7ms ± 1%    14.9ms ±18%  +26.66%  (p=0.008 n=5+5)
ImagePackageCatalogers/ruby-gemspec-cataloger-2              1.31ms ± 1%    1.57ms ± 0%  +19.48%  (p=0.016 n=4+5)
ImagePackageCatalogers/python-package-cataloger-2            3.29ms ± 2%    3.89ms ± 2%  +18.40%  (p=0.008 n=5+5)
ImagePackageCatalogers/php-composer-installed-cataloger-2    1.06ms ± 0%    1.27ms ± 1%  +19.98%  (p=0.008 n=5+5)
ImagePackageCatalogers/javascript-package-cataloger-2         745µs ± 1%     904µs ± 0%  +21.29%  (p=0.008 n=5+5)
ImagePackageCatalogers/node-binary-cataloger-2               6.75µs ± 0%    8.12µs ± 1%  +20.27%  (p=0.008 n=5+5)
ImagePackageCatalogers/dpkgdb-cataloger-2                     865µs ± 1%    1025µs ± 1%  +18.55%  (p=0.008 n=5+5)
ImagePackageCatalogers/rpm-db-cataloger-2                    1.27ms ± 1%    1.51ms ± 1%  +18.66%  (p=0.008 n=5+5)
ImagePackageCatalogers/java-cataloger-2                      14.4ms ± 1%    17.3ms ± 1%  +20.20%  (p=0.008 n=5+5)
ImagePackageCatalogers/apkdb-cataloger-2                     1.27ms ± 2%    1.49ms ± 1%  +16.83%  (p=0.008 n=5+5)
ImagePackageCatalogers/go-module-binary-cataloger-2          6.83µs ± 2%    8.12µs ± 0%  +18.93%  (p=0.008 n=5+5)
ImagePackageCatalogers/dotnet-deps-cataloger-2               1.40ms ± 1%    1.61ms ± 0%  +15.13%  (p=0.016 n=5+4)
ImagePackageCatalogers/portage-cataloger-2                    705µs ± 1%     844µs ± 1%  +19.62%  (p=0.008 n=5+5)

name                                                       old alloc/op   new alloc/op   delta
ImagePackageCatalogers/alpmdb-cataloger-2                    5.27MB ± 0%    5.27MB ± 0%     ~     (p=0.690 n=5+5)
ImagePackageCatalogers/ruby-gemspec-cataloger-2               204kB ± 0%     204kB ± 0%     ~     (p=0.222 n=5+5)
ImagePackageCatalogers/python-package-cataloger-2             960kB ± 0%     959kB ± 0%     ~     (p=0.730 n=5+4)
ImagePackageCatalogers/php-composer-installed-cataloger-2     216kB ± 0%     216kB ± 0%     ~     (p=0.841 n=5+5)
ImagePackageCatalogers/javascript-package-cataloger-2         159kB ± 0%     159kB ± 0%   +0.11%  (p=0.008 n=5+5)
ImagePackageCatalogers/node-binary-cataloger-2               1.12kB ± 0%    1.12kB ± 0%     ~     (all equal)
ImagePackageCatalogers/dpkgdb-cataloger-2                     200kB ± 0%     200kB ± 0%     ~     (p=0.056 n=5+5)
ImagePackageCatalogers/rpm-db-cataloger-2                     302kB ± 0%     302kB ± 0%     ~     (p=1.000 n=5+5)
ImagePackageCatalogers/java-cataloger-2                      3.45MB ± 0%    3.46MB ± 0%     ~     (p=0.111 n=5+4)
ImagePackageCatalogers/apkdb-cataloger-2                     1.25MB ± 0%    1.25MB ± 0%   +0.11%  (p=0.008 n=5+5)
ImagePackageCatalogers/go-module-binary-cataloger-2          1.12kB ± 0%    1.12kB ± 0%     ~     (all equal)
ImagePackageCatalogers/dotnet-deps-cataloger-2                378kB ± 0%     379kB ± 0%   +0.19%  (p=0.008 n=5+5)
ImagePackageCatalogers/portage-cataloger-2                    137kB ± 0%     137kB ± 0%     ~     (p=0.151 n=5+5)

name                                                       old allocs/op  new allocs/op  delta
ImagePackageCatalogers/alpmdb-cataloger-2                     85.7k ± 0%     85.7k ± 0%     ~     (p=1.000 n=4+5)
ImagePackageCatalogers/ruby-gemspec-cataloger-2               4.24k ± 0%     4.24k ± 0%     ~     (all equal)
ImagePackageCatalogers/python-package-cataloger-2             16.5k ± 0%     16.5k ± 0%     ~     (p=0.905 n=5+5)
ImagePackageCatalogers/php-composer-installed-cataloger-2     5.51k ± 0%     5.51k ± 0%     ~     (p=0.159 n=5+5)
ImagePackageCatalogers/javascript-package-cataloger-2         3.31k ± 0%     3.31k ± 0%     ~     (all equal)
ImagePackageCatalogers/node-binary-cataloger-2                 38.0 ± 0%      38.0 ± 0%     ~     (all equal)
ImagePackageCatalogers/dpkgdb-cataloger-2                     4.51k ± 0%     4.51k ± 0%     ~     (all equal)
ImagePackageCatalogers/rpm-db-cataloger-2                     8.11k ± 0%     8.11k ± 0%     ~     (all equal)
ImagePackageCatalogers/java-cataloger-2                       57.5k ± 0%     57.5k ± 0%     ~     (p=0.937 n=5+5)
ImagePackageCatalogers/apkdb-cataloger-2                      5.39k ± 0%     5.39k ± 0%     ~     (p=1.000 n=4+5)
ImagePackageCatalogers/go-module-binary-cataloger-2            38.0 ± 0%      38.0 ± 0%     ~     (all equal)
ImagePackageCatalogers/dotnet-deps-cataloger-2                7.33k ± 0%     7.33k ± 0%     ~     (p=0.167 n=5+5)
ImagePackageCatalogers/portage-cataloger-2                    3.58k ± 0%     3.58k ± 0%     ~     (all equal)

@wagoodman wagoodman merged commit e0acfa9 into main Nov 2, 2022
@wagoodman wagoodman deleted the fix-s3-version-update branch November 2, 2022 15:48
GijsCalis pushed a commit to GijsCalis/syft that referenced this pull request Feb 19, 2024
Signed-off-by: Alex Goodman <[email protected]>

Signed-off-by: Alex Goodman <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants