Port javascript cataloger to new generic cataloger pattern #1308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alex Goodman <[email protected]>
wagoodman
force-pushed
the
update-javascript-generic-cataloger
branch
from
57ff3c2 to
50d7cbf
Compare
Benchmark Test ResultsBenchmark results from the latest changes vs base branch |
kzantow
approved these changes
Nov 2, 2022
| parsedPackages.Add(currentPackage + "@" + currentVersion) | ||
| } | ||
|
|
||
| if err := scanner.Err(); err != nil { | ||
| return nil, nil, fmt.Errorf("failed to parse yarn.lock file: %w", err) | ||
| } | ||
|
|
||
| return packages, nil, nil | ||
| pkg.Sort(pkgs) |
There was a problem hiding this comment.
Is the main reason for sorting each of these functions for stable results in tests?
GijsCalis
pushed a commit
to GijsCalis/syft
that referenced
this pull request
Feb 19, 2024
) Signed-off-by: Alex Goodman <[email protected]> Signed-off-by: Alex Goodman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #1281 , porting the javascript cataloger to the new
generic.Cataloger.