Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: unterminated quoted string #1300

Merged
merged 1 commit into from
Oct 31, 2022
Merged

fix: unterminated quoted string #1300

merged 1 commit into from
Oct 31, 2022

Conversation

spiffcs
Copy link
Contributor

@spiffcs spiffcs commented Oct 31, 2022

Signed-off-by: Christopher Phillips [email protected]

Signed-off-by: Christopher Phillips <[email protected]>
@spiffcs spiffcs enabled auto-merge (squash) October 31, 2022 19:42
@spiffcs spiffcs disabled auto-merge October 31, 2022 19:42
@spiffcs spiffcs enabled auto-merge (squash) October 31, 2022 19:42
@github-actions
Copy link

Benchmark Test Results

Benchmark results from the latest changes vs base branch
name                                                       old time/op    new time/op    delta
ImagePackageCatalogers/alpmdb-cataloger-2                    16.3ms ±11%    11.4ms ± 1%  -30.15%  (p=0.008 n=5+5)
ImagePackageCatalogers/ruby-gemspec-cataloger-2              1.89ms ±15%    1.28ms ± 0%  -32.54%  (p=0.016 n=5+4)
ImagePackageCatalogers/python-package-cataloger-2            4.38ms ± 4%    3.25ms ± 0%  -25.81%  (p=0.008 n=5+5)
ImagePackageCatalogers/php-composer-installed-cataloger-2    1.38ms ± 2%    1.03ms ± 0%  -25.45%  (p=0.008 n=5+5)
ImagePackageCatalogers/javascript-package-cataloger-2         955µs ± 2%     719µs ± 0%  -24.69%  (p=0.008 n=5+5)
ImagePackageCatalogers/node-binary-cataloger-2               8.09µs ± 4%    6.75µs ± 1%  -16.53%  (p=0.008 n=5+5)
ImagePackageCatalogers/dpkgdb-cataloger-2                    1.16ms ± 3%    0.83ms ± 1%  -28.02%  (p=0.008 n=5+5)
ImagePackageCatalogers/rpm-db-cataloger-2                    1.68ms ± 5%    1.21ms ± 0%  -28.03%  (p=0.008 n=5+5)
ImagePackageCatalogers/java-cataloger-2                      18.0ms ± 1%    14.0ms ± 0%  -22.52%  (p=0.008 n=5+5)
ImagePackageCatalogers/apkdb-cataloger-2                     1.64ms ± 2%    1.25ms ± 2%  -23.41%  (p=0.008 n=5+5)
ImagePackageCatalogers/go-module-binary-cataloger-2          8.04µs ± 5%    6.70µs ± 1%  -16.59%  (p=0.008 n=5+5)
ImagePackageCatalogers/dotnet-deps-cataloger-2               1.75ms ± 3%    1.34ms ± 1%  -23.23%  (p=0.008 n=5+5)
ImagePackageCatalogers/portage-cataloger-2                    886µs ± 3%     666µs ± 0%  -24.90%  (p=0.008 n=5+5)

name                                                       old alloc/op   new alloc/op   delta
ImagePackageCatalogers/alpmdb-cataloger-2                    5.27MB ± 0%    5.27MB ± 0%     ~     (p=1.000 n=5+5)
ImagePackageCatalogers/ruby-gemspec-cataloger-2               204kB ± 0%     204kB ± 0%     ~     (p=0.095 n=5+5)
ImagePackageCatalogers/python-package-cataloger-2             959kB ± 0%     961kB ± 0%   +0.21%  (p=0.008 n=5+5)
ImagePackageCatalogers/php-composer-installed-cataloger-2     216kB ± 0%     217kB ± 0%   +0.15%  (p=0.016 n=5+5)
ImagePackageCatalogers/javascript-package-cataloger-2         159kB ± 0%     159kB ± 0%   +0.14%  (p=0.008 n=5+5)
ImagePackageCatalogers/node-binary-cataloger-2               1.12kB ± 0%    1.12kB ± 0%     ~     (all equal)
ImagePackageCatalogers/dpkgdb-cataloger-2                     200kB ± 0%     200kB ± 0%   +0.17%  (p=0.008 n=5+5)
ImagePackageCatalogers/rpm-db-cataloger-2                     302kB ± 0%     302kB ± 0%   +0.17%  (p=0.008 n=5+5)
ImagePackageCatalogers/java-cataloger-2                      3.45MB ± 0%    3.45MB ± 0%     ~     (p=0.421 n=5+5)
ImagePackageCatalogers/apkdb-cataloger-2                     1.25MB ± 0%    1.26MB ± 0%     ~     (p=0.421 n=5+5)
ImagePackageCatalogers/go-module-binary-cataloger-2          1.12kB ± 0%    1.12kB ± 0%     ~     (all equal)
ImagePackageCatalogers/dotnet-deps-cataloger-2                378kB ± 0%     378kB ± 0%     ~     (p=1.000 n=5+5)
ImagePackageCatalogers/portage-cataloger-2                    137kB ± 0%     138kB ± 0%   +0.14%  (p=0.008 n=5+5)

name                                                       old allocs/op  new allocs/op  delta
ImagePackageCatalogers/alpmdb-cataloger-2                     85.7k ± 0%     85.7k ± 0%   +0.00%  (p=0.016 n=5+4)
ImagePackageCatalogers/ruby-gemspec-cataloger-2               4.24k ± 0%     4.24k ± 0%     ~     (all equal)
ImagePackageCatalogers/python-package-cataloger-2             16.5k ± 0%     16.5k ± 0%     ~     (p=0.524 n=5+5)
ImagePackageCatalogers/php-composer-installed-cataloger-2     5.51k ± 0%     5.51k ± 0%     ~     (p=1.000 n=5+5)
ImagePackageCatalogers/javascript-package-cataloger-2         3.31k ± 0%     3.31k ± 0%     ~     (all equal)
ImagePackageCatalogers/node-binary-cataloger-2                 38.0 ± 0%      38.0 ± 0%     ~     (all equal)
ImagePackageCatalogers/dpkgdb-cataloger-2                     4.51k ± 0%     4.51k ± 0%     ~     (all equal)
ImagePackageCatalogers/rpm-db-cataloger-2                     8.11k ± 0%     8.11k ± 0%     ~     (all equal)
ImagePackageCatalogers/java-cataloger-2                       57.5k ± 0%     57.5k ± 0%     ~     (p=0.540 n=5+5)
ImagePackageCatalogers/apkdb-cataloger-2                      5.39k ± 0%     5.39k ± 0%     ~     (p=1.000 n=5+5)
ImagePackageCatalogers/go-module-binary-cataloger-2            38.0 ± 0%      38.0 ± 0%     ~     (all equal)
ImagePackageCatalogers/dotnet-deps-cataloger-2                7.33k ± 0%     7.33k ± 0%     ~     (all equal)
ImagePackageCatalogers/portage-cataloger-2                    3.58k ± 0%     3.58k ± 0%     ~     (all equal)

@spiffcs spiffcs merged commit 8e2fc29 into main Oct 31, 2022
@spiffcs spiffcs deleted the makefile-patch branch October 31, 2022 20:07
GijsCalis pushed a commit to GijsCalis/syft that referenced this pull request Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants