Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update golang cataloger to new generic cataloger pattern #1289

Merged
merged 1 commit into from
Oct 25, 2022
Merged

Update golang cataloger to new generic cataloger pattern #1289

merged 1 commit into from
Oct 25, 2022

Conversation

wagoodman
Copy link
Contributor

@wagoodman wagoodman commented Oct 25, 2022 •
edited
Loading

Follow up to #1281 , porting the golang cataloger to the new generic.Cataloger.

note: this needs to be rebased when the #1288 PR merges

@wagoodman wagoodman requested a review from a team October 25, 2022 15:18
@wagoodman wagoodman force-pushed the update-deb-generic-cataloger branch from b39bd71 to 0f73ff8 Compare October 25, 2022 15:21
@wagoodman wagoodman force-pushed the update-golang-generic-cataloger branch from 740b3c3 to 7e97d76 Compare October 25, 2022 15:22
@wagoodman wagoodman changed the base branch from update-deb-generic-cataloger to main October 25, 2022 15:23
@wagoodman wagoodman enabled auto-merge (squash) October 25, 2022 15:23
@wagoodman wagoodman changed the base branch from main to update-deb-generic-cataloger October 25, 2022 15:25
@github-actions
Copy link

github-actions bot commented Oct 25, 2022 •
edited
Loading

Benchmark Test Results

Benchmark results from the latest changes vs base branch 
name                                                       old time/op    new time/op    delta
ImagePackageCatalogers/alpmdb-cataloger-2                    12.9ms ± 3%    11.6ms ± 1%   -10.68%  (p=0.008 n=5+5)
ImagePackageCatalogers/ruby-gemspec-cataloger-2              1.53ms ± 6%    1.33ms ±12%   -12.54%  (p=0.032 n=5+5)
ImagePackageCatalogers/python-package-cataloger-2            3.74ms ± 1%    3.31ms ± 0%   -11.49%  (p=0.008 n=5+5)
ImagePackageCatalogers/php-composer-installed-cataloger-2    1.20ms ± 3%    1.04ms ± 0%   -13.45%  (p=0.008 n=5+5)
ImagePackageCatalogers/javascript-package-cataloger-2         833µs ± 1%     722µs ± 0%   -13.37%  (p=0.008 n=5+5)
ImagePackageCatalogers/dpkgdb-cataloger-2                     975µs ± 3%     839µs ± 1%   -13.94%  (p=0.008 n=5+5)
ImagePackageCatalogers/rpm-db-cataloger-2                    1.46ms ± 2%    1.23ms ± 0%   -15.65%  (p=0.008 n=5+5)
ImagePackageCatalogers/java-cataloger-2                      16.3ms ± 1%    14.8ms ± 0%    -9.41%  (p=0.008 n=5+5)
ImagePackageCatalogers/apkdb-cataloger-2                     1.35ms ± 6%    1.23ms ± 1%    -8.79%  (p=0.008 n=5+5)
ImagePackageCatalogers/go-module-binary-cataloger-2          2.64µs ± 3%    6.87µs ± 1%  +160.55%  (p=0.008 n=5+5)
ImagePackageCatalogers/dotnet-deps-cataloger-2               1.57ms ± 2%    1.39ms ± 1%   -11.12%  (p=0.008 n=5+5)
ImagePackageCatalogers/portage-cataloger-2                    801µs ± 1%     670µs ± 1%   -16.39%  (p=0.008 n=5+5)

name                                                       old alloc/op   new alloc/op   delta
ImagePackageCatalogers/alpmdb-cataloger-2                    5.26MB ± 0%    5.26MB ± 0%      ~     (p=0.421 n=5+5)
ImagePackageCatalogers/ruby-gemspec-cataloger-2               202kB ± 0%     202kB ± 0%      ~     (p=0.190 n=5+4)
ImagePackageCatalogers/python-package-cataloger-2             945kB ± 0%     944kB ± 0%      ~     (p=0.548 n=5+5)
ImagePackageCatalogers/php-composer-installed-cataloger-2     213kB ± 0%     213kB ± 0%      ~     (p=0.690 n=5+5)
ImagePackageCatalogers/javascript-package-cataloger-2         158kB ± 0%     158kB ± 0%      ~     (p=0.095 n=5+5)
ImagePackageCatalogers/dpkgdb-cataloger-2                     199kB ± 0%     199kB ± 0%      ~     (p=0.690 n=5+5)
ImagePackageCatalogers/rpm-db-cataloger-2                     302kB ± 0%     302kB ± 0%      ~     (p=0.151 n=5+5)
ImagePackageCatalogers/java-cataloger-2                      3.44MB ± 0%    3.44MB ± 0%    +0.09%  (p=0.016 n=5+5)
ImagePackageCatalogers/apkdb-cataloger-2                     1.25MB ± 0%    1.25MB ± 0%      ~     (p=0.841 n=5+5)
ImagePackageCatalogers/go-module-binary-cataloger-2            672B ± 0%     1116B ± 0%   +66.07%  (p=0.008 n=5+5)
ImagePackageCatalogers/dotnet-deps-cataloger-2                377kB ± 0%     376kB ± 0%    -0.07%  (p=0.016 n=5+5)
ImagePackageCatalogers/portage-cataloger-2                    136kB ± 0%     136kB ± 0%      ~     (p=0.738 n=5+5)

name                                                       old allocs/op  new allocs/op  delta
ImagePackageCatalogers/alpmdb-cataloger-2                     85.7k ± 0%     85.7k ± 0%      ~     (p=1.000 n=5+5)
ImagePackageCatalogers/ruby-gemspec-cataloger-2               4.24k ± 0%     4.24k ± 0%      ~     (all equal)
ImagePackageCatalogers/python-package-cataloger-2             16.5k ± 0%     16.5k ± 0%      ~     (p=0.111 n=5+5)
ImagePackageCatalogers/php-composer-installed-cataloger-2     5.50k ± 0%     5.50k ± 0%      ~     (p=0.484 n=5+5)
ImagePackageCatalogers/javascript-package-cataloger-2         3.31k ± 0%     3.31k ± 0%      ~     (p=0.079 n=4+5)
ImagePackageCatalogers/dpkgdb-cataloger-2                     4.50k ± 0%     4.50k ± 0%      ~     (all equal)
ImagePackageCatalogers/rpm-db-cataloger-2                     8.11k ± 0%     8.11k ± 0%      ~     (all equal)
ImagePackageCatalogers/java-cataloger-2                       57.5k ± 0%     57.5k ± 0%      ~     (p=0.135 n=5+5)
ImagePackageCatalogers/apkdb-cataloger-2                      5.39k ± 0%     5.39k ± 0%      ~     (p=1.000 n=5+4)
ImagePackageCatalogers/go-module-binary-cataloger-2            15.0 ± 0%      38.0 ± 0%  +153.33%  (p=0.008 n=5+5)
ImagePackageCatalogers/dotnet-deps-cataloger-2                7.32k ± 0%     7.32k ± 0%      ~     (all equal)
ImagePackageCatalogers/portage-cataloger-2                    3.58k ± 0%     3.58k ± 0%      ~     (all equal)

Base automatically changed from update-deb-generic-cataloger to main October 25, 2022 15:47
@wagoodman wagoodman force-pushed the update-golang-generic-cataloger branch from 7e97d76 to a7e3cf8 Compare October 25, 2022 16:15
@wagoodman wagoodman merged commit 6826d76 into main Oct 25, 2022
@wagoodman wagoodman deleted the update-golang-generic-cataloger branch October 25, 2022 16:42
GijsCalis pushed a commit to GijsCalis/syft that referenced this pull request Feb 19, 2024
@wagoodman
port golang cataloger to new generic cataloger pattern (anchore#1289)
97efd92 
Signed-off-by: Alex Goodman <[email protected]>

Signed-off-by: Alex Goodman <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kzantow kzantow kzantow approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wagoodman @kzantow