-
Notifications
You must be signed in to change notification settings - Fork 593
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: check pom properties for version (#1251) #1278
Conversation
20ca93f
to
f2ca008
Compare
@kzantow - I think that last commit accomplishes what you're looking for. Let me know |
Signed-off-by: Rob Tompkins <[email protected]>
Signed-off-by: Rob Tompkins <[email protected]>
@chtompki -- if you'd like, I can make a couple small updates to this that I think will get it to the finish line |
Go for it. I'm curious to see what you do. I'll learn from that and try to use that style for any future PRs I submit |
Signed-off-by: Keith Zantow <[email protected]>
@chtompki thanks -- I went down a little bit of a rabbit hole that I wouldn't expect most people to do in order to support project properties like |
Cool...I see what you've done here, and that helps me think about the way I might make an analogous change for gradle. I don't have a good example for gradle yet, and I've only seen it once. But, I'm thinking about trying to make that my next contribution |
I think this closes #1251. I'm not sure but there may be an analogous issue with gradle. I'll see if I can find and example and submit a similar fix.