Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1245 Update SPDX license list to 3.18 #1259

Merged
merged 4 commits into from
Oct 28, 2022
Merged

Fix #1245 Update SPDX license list to 3.18 #1259

merged 4 commits into from
Oct 28, 2022

Conversation

vargenau
Copy link
Contributor

@vargenau vargenau commented Oct 12, 2022

File licenses.json taken from https://github.com/spdx/license-list-data/releases/tag/v3.18

Signed-off-by: Marc-Etienne Vargenau [email protected]

Fixes: #1245

@kzantow
Copy link
Contributor

kzantow commented Oct 17, 2022

Hi @vargenau -- I ran the tests locally it looks like unit tests are failing here (I suspect CI will tell us the same), could you have a look?

@kzantow
Copy link
Contributor

kzantow commented Oct 17, 2022

A quick note: this change to the test fixture has seemed to break the tests, which were previously working with the existing fixture. I think this may not be needed?

@vargenau
Copy link
Contributor Author

Hi @vargenau -- I ran the tests locally it looks like unit tests are failing here (I suspect CI will tell us the same), could you have a look?

Hi @kzantow,

I have fixed the unit test that was failing. It should be OK now.

@kzantow
Copy link
Contributor

kzantow commented Oct 18, 2022

@vargenau I don't see any new commits here, was there something you meant to push?

@kzantow
Copy link
Contributor

kzantow commented Oct 24, 2022

Hi @vargenau -- it looks like the unit tests are still failing. If you'd like to run them locally, assuming you have Docker installed and running you can run make unit in order to make sure your changes are going to work.

@vargenau
Copy link
Contributor Author

Hi @vargenau -- it looks like the unit tests are still failing. If you'd like to run them locally, assuming you have Docker installed and running you can run make unit in order to make sure your changes are going to work.

Hi @kzantow

I have fixed the tests. Sorry, but I still have issues running the tests locally, I have an error in downloading a file.

@spiffcs spiffcs merged commit dd89461 into anchore:main Oct 28, 2022
GijsCalis pushed a commit to GijsCalis/syft that referenced this pull request Feb 19, 2024
* Fix anchore#1245 Update SPDX license list to 3.18

Signed-off-by: Marc-Etienne Vargenau <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update SPDX license list to 3.18
3 participants