-
Notifications
You must be signed in to change notification settings - Fork 587
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug: remove chance for panic; provide default attestation path #1214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Christopher Phillips <[email protected]>
- on format identification failure provide default path for succesful command execution Signed-off-by: Christopher Phillips <[email protected]>
Signed-off-by: Christopher Phillips <[email protected]>
Benchmark Test ResultsBenchmark results from the latest changes vs base branch
|
kzantow
approved these changes
Sep 19, 2022
spiffcs
added a commit
to luhring/syft
that referenced
this pull request
Sep 19, 2022
* main: bug: remove chance for panic; provide default attestation path (anchore#1214) refactor: update Makefile organization; update DEVELOPING.md instructions (anchore#1212) refactor: replace ioutil=>io; update linter (anchore#1211) Update bootstrap tools to latest versions. (anchore#1204) Add gosimports (anchore#1205) refactor: move formats from internal into syft module (anchore#1172) warn on errors from RPM DB parsing (anchore#1200) docs: improve Singularity image source docs (anchore#1190) Signed-off-by: Christopher Phillips <[email protected]>
spiffcs
added a commit
that referenced
this pull request
Sep 19, 2022
Signed-off-by: Christopher Phillips <[email protected]>
aiwantaozi
pushed a commit
to aiwantaozi/syft
that referenced
this pull request
Oct 20, 2022
spiffcs
added a commit
that referenced
this pull request
Oct 21, 2022
Signed-off-by: Christopher Phillips <[email protected]>
spiffcs
added a commit
that referenced
this pull request
Oct 21, 2022
Signed-off-by: Christopher Phillips <[email protected]>
GijsCalis
pushed a commit
to GijsCalis/syft
that referenced
this pull request
Feb 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #1210
Given a user could provide a typo value for their desired output, the
format
value in attest had a chance to benil
.This PR adds a guard against
FormatByName
returning nil by adding a default format attestation path assyft-json
.Another option is we could error out and inform the user that their format is unrecognized rather than providing a default. I'm open to either approach but chose to try and provide a successful command rather than error case in this instance.
A CLI test has been added to cover this typo case.
Signed-off-by: Christopher Phillips [email protected]