-
Notifications
You must be signed in to change notification settings - Fork 593
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for dependency relationships for alpine (apk) #1063
Conversation
@tgerla I took this out of draft - if you push your changes I can review |
bbf6747
to
ddfcee1
Compare
Hi @spiffcs (and anyone else interested) -- I think this one is ready to go. Can you please review my last commit, "adjust test conditions"? I think I've updated the test correctly, but I am Go noob. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like there are a couple // TODO
s that might be important to fill out on this one -- what do you think?
ddfcee1
to
ed5c9c9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a question about schema change procedure as well as separator being used. When we settle on the right separator we might want to add a quick test to be sure the split is behaving correctly.
Also small nit on the strings usage
splits := strings.Split(provides, "=")
if strings.Contains(splits[0], "=") {
// protect against unsuccesful split
}
@tgerla it looks like there may be more things that were not originally in scope that need to be considered as part of this PR. It looks like the https://wiki.alpinelinux.org/wiki/Apk_spec page got a really healthy update over the last few months to help interpret an APK index vs installed DB file, which will be really helpful for determining the missing bits. I'd be happy to pair on this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few non-blocking questions...
Signed-off-by: Dan Luhring <[email protected]>
Signed-off-by: Alex Goodman <[email protected]>
Signed-off-by: Christopher Phillips <[email protected]>
Signed-off-by: Timothy Gerla <[email protected]>
Signed-off-by: Christopher Phillips <[email protected]>
Signed-off-by: Alex Goodman <[email protected]>
Signed-off-by: Alex Goodman <[email protected]>
Signed-off-by: Alex Goodman <[email protected]>
Signed-off-by: Alex Goodman <[email protected]>
Signed-off-by: Alex Goodman <[email protected]>
e98f483
to
635afb7
Compare
Signed-off-by: Alex Goodman <[email protected]>
This one should not have been squashed 😄 |
* Fix type of pull deps and add support for provides Signed-off-by: Dan Luhring <[email protected]> * [wip] apk dependency lookup Signed-off-by: Alex Goodman <[email protected]> * update whitespace for linter Signed-off-by: Christopher Phillips <[email protected]> * adjust test conditions Signed-off-by: Timothy Gerla <[email protected]> * fix TODOs and improve Provides parser * run simports after main merge Signed-off-by: Christopher Phillips <[email protected]> * add tests to cover apk relationship parsing cases Signed-off-by: Alex Goodman <[email protected]> * generate JSON schema for breaking changes to apk metadata Signed-off-by: Alex Goodman <[email protected]> * update tests to account for additional dependencies Signed-off-by: Alex Goodman <[email protected]> * [wip] fix relationship encoding for cyclonedx Signed-off-by: Alex Goodman <[email protected]> * simplify package relationships that can be expressed Signed-off-by: Alex Goodman <[email protected]> Signed-off-by: Dan Luhring <[email protected]> Signed-off-by: Alex Goodman <[email protected]> Signed-off-by: Christopher Phillips <[email protected]> Signed-off-by: Timothy Gerla <[email protected]> Co-authored-by: Alex Goodman <[email protected]> Co-authored-by: Christopher Phillips <[email protected]> Co-authored-by: Timothy Gerla <[email protected]>
Partially addresses #572