Use SBOM descriptor version #1011
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jonas Xavier <[email protected]>
Signed-off-by: Jonas Xavier <[email protected]>
Signed-off-by: Jonas Xavier <[email protected]>
wagoodman
reviewed
May 24, 2022
internal/formats/spdx22tagvalue/test-fixtures/snapshot/TestSPDXJSONSPDXIDs.golden
Outdated
Show resolved
Hide resolved
Signed-off-by: Jonas Xavier <[email protected]>
Signed-off-by: Jonas Xavier <[email protected]>
spiffcs
approved these changes
May 25, 2022
|
didn't get to this before the merge, can we add some explicit tests to ensure we grab the version from the descriptor and not the lib approach (so not lean on snapshot tests here)? |
GijsCalis
pushed a commit
to GijsCalis/syft
that referenced
this pull request
Feb 19, 2024
* Use SBOM descriptor version Signed-off-by: Jonas Xavier <[email protected]> * Update tests Signed-off-by: Jonas Xavier <[email protected]> * CycloneDX extract tools metadata in decoding stage Signed-off-by: Jonas Xavier <[email protected]> * add descriptor to spdx tag-value test Signed-off-by: Jonas Xavier <[email protected]> * remove comment Signed-off-by: Jonas Xavier <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix lack of version info when Syft is used a library.
0.0.0-devFix: #1010
Signed-off-by: Jonas Xavier [email protected]