Enhance container image labels for ArtifactHub #639
Conversation
.goreleaser.yaml
Outdated
| - "--label=io.artifacthub.package.readme-url=https://raw.githubusercontent.com/anchore/grype/main/README.md" | ||
| - "--label=io.artifacthub.package.logo-url=https://user-images.githubusercontent.com/5199289/136855393-d0a9eef9-ccf1-4e2b-9d7c-7aad16a567e5.png" | ||
| - "--label=io.artifacthub.package.license=Apache-2.0" | ||
| - "--label=org.opencontainers.image.description=A vulnerability scanner for container images and filesystems" |
There was a problem hiding this comment.
Probably link to https://github.com/anchore/grype#readme ?
There was a problem hiding this comment.
The same for grype, I think this README file URL is for the ArtifactHub to be able to render the README, so, it is not for the end-users of grype, am I right @dirien?
There was a problem hiding this comment.
Oh, that's interesting so reads GitHub flavored markdown?
There was a problem hiding this comment.
I think so, yes 🙋🏻♂️
There was a problem hiding this comment.
Because, @dirien have been worked for the GoReleaser project for the same purpose, see.
goreleaser/goreleaser#2830
https://artifacthub.io/packages/container/goreleaser/goreleaser
|
I got a little more info, it might be good to add these directly to the Dockerfile, as is done here: https://github.com/anchore/syft/blob/main/Dockerfile#L18-L26 this way it's all just done in one place, WDYT @developer-guy ? |
Yeah, definitely a good idea 🙋🏻♂️❤️ |
…mage in artifacthub Signed-off-by: Batuhan Apaydın <[email protected]>
developer-guy
force-pushed
the
feature/613
branch
from
cb4f93c
to
9beabab
Compare
wagoodman
changed the title
Signed-off-by: Batuhan Apaydın [email protected]
Fixes #613