Drop DB v6 indexes on close #2335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wagoodman
added
the
changelog-ignore
Signed-off-by: Alex Goodman <[email protected]>
wagoodman
force-pushed
the
v6-drop-index
branch
from
5d4079c to
e795ae5
Compare
kzantow
reviewed
Dec 16, 2024
| "immutable=1", | ||
| "cache=shared", | ||
| "mode=ro", | ||
| var heavyWriteStatements = []string{ |
There was a problem hiding this comment.
nit: this doesn't seem to have options directly related to write performance but rather memory, with an option named allowLargeMemoryFootprint should this be largeMemoryFootprintStatements?
There was a problem hiding this comment.
#2335 (comment) so when there are heavy writes expected we want to allow for a larger memory footprint (to improve write performance).
| } | ||
| } | ||
|
|
||
| if cfg.truncate && cfg.allowLargeMemoryFootprint { |
There was a problem hiding this comment.
Is the memory footprint related to truncating?
There was a problem hiding this comment.
it is -- when we start with an empty DB we will be doing a lot of writing (and allowing for a larger memory footprint in those cases allows for writing to the DB much faster).
kzantow
approved these changes
Dec 16, 2024
Signed-off-by: Alex Goodman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the following adjustments to the v6 store:
When opening a DB for reading or writing:
When opening an EMPTY db for writing:
When closing a newly-populated DB:
When importing a DB:
v6.Hydrater)Other changes made in this PR:
internal.NewDBtov6.NewLowLevelDBso that it has direct access to initial data and models to be migrated (so getting agorm.DBinstance is consistent)