chore: remove quality gate Makefile db age check #2036
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Keith Zantow <[email protected]>
kzantow
added
the
changelog-ignore
| $(YARDSTICK) -v result capture -r $(RESULT_SET) | ||
|
|
||
| .PHONY: check-db | ||
| check-db: |
There was a problem hiding this comment.
Do we need to set a DB max age in yardstick config or something to ensure that we don't run grype quality against a super old DB forever?
There was a problem hiding this comment.
I don't really think so, we already have this workflow: https://github.com/anchore/grype/blob/main/.github/workflows/update-quality-gate-db.yml
wagoodman
approved these changes
Aug 12, 2024
This comment was marked as outdated.
This comment was marked as outdated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we lowered the number of days in the database listing file, it causes an issue in the quality tests here, since the Makefile validates the database exists in the listing file and would require updating the database URL quite frequently. This PR just removes the pseudo-age-check since we're already updating this every month with an automated workflow.