Issue #661 #662
Merged
Issue #661 #662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjaakluthart
suggested changes
Jun 10, 2017
src/menu/index.jsx
Outdated
| @@ -17,11 +30,30 @@ const Menu = ({ children, open, header, toggleMenu, style, headerStyle, ...custo | |||
| ) | |||
| )); | |||
|
|
|||
| if (sidebar || !toggleMenu) { | |||
There was a problem hiding this comment.
With this check the sidebar prop is redundant, remove it. Change to documentation for toggleMenu to something like this Toggle the Menu's visibility, Menu will render as a sidebar if this prop is not supplied.
There was a problem hiding this comment.
Could you also change the Nav in docs to use the sidebar Menu?
sjaakluthart
approved these changes
Jun 10, 2017
|
I've added random icons to the menu!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue #661