-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[6.0.0] Added infiteScroll to List, removed nestedListItem capabilities, adjusted Message component, adjusted DateSeparator component and removed date-fns dependency #1039
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* WIP emoji parser to new `emoji.js`. * WIP emoji-parsing files. * Added prettier. * Ignored emojione.json. * Fixed parse script. * Added emoji.sh. * Updated emojione. * Added tone0. * Fixed modifier titles. * Removed log. * Removed svgSprites prop, added cdn url fix. * Added fontSize. * Changed script to fix error in emojione.json. * Removed statics. * Added attribution to component. * Added attribution to docs page. * Added attribution to README. * Fixed color. * Docgen. * Added attribution. * Prettiered file.
* 🔨 Refactored list-item to fix alignment issue. Fixed issue #648. #648 * ✅ Added tests. * 🐛 Removed redundant transform. * 💚 Fixed test. * 🎨 Added nestedLevel prop and passthrough. * 🎨 Added nestedLevel prop and passthrough. * 💄 Added style handling for nestedLevel prop. * 💚 Fixed tests for root styles. * ✅ Added test for nestingLevel styles. * 📝 Added example shownig nestedLevel prop at work. * 📝 DocGen. * 📝 Fixed docs nav throwing warning. * 🚨 Fixed linting errors.
* Pass value directly, event did not persist. * Docgen. * Removed console.log.
…onClick not required, fixed bug with SearchBox changeQuery by passing value instead of event.
* Updated LABELS.md. * Added missing label.
* admin-badge consistency * alert consistency * small fixes * app-header consistency * small consistency changes fot tests * channel-header consistency * checkbox consistency * dialog consistency * Fixed input tests and added consistency * lightbox consistency * Fixed list tests and added consistency * Fixed menu-item tests and added consistency
…t, fixed Pagination buttons, added tests.
* Added correct styling for td items. * DocGen.
* Fixed uncoverd lines for emoji-menu/get-style test. * New structure for correct testing. * Added index test for emoji-menu. * Made new internal function for store-emoji. * Removed old storage function. * Used new internal function in EmojiMenu. Fixes #1009. * Added store to dependencies. * Made sure chosen emoji gets moved to the first place when its already stored. * Updated sinon package. * Fixed broken stubs after package update. * Added test for store-emoji. * Cleaned the campgrounds.
* Added custom style possibilities to unchecked element. * DocGen. * Added to tests. * fixed typo.
* Only render label if it is passed. * Only render label if it is passed. * Changed to single line. * Fixed broken test. * Changed code styling of radio-group file. * Changed code styling of radio-button file. * Changed code styling of slider file. * Made sure html doesnt get rendered if label is not passed in switch. Fixes #1020. * Changed code styling of tab file.
* Added CheckboxGroup component. Fixes #1025. * Adjusted docs comments. * DocGen. * Adjusted docs page. * Adjusted example for checkbox docs component. * Fixed example. * Moved custom prop to last prop. * Created getStyles test for CheckboxGroup. * Added index test. * Adjusted checkbox docs page.
…d store-emoji file and added custom styling possibilities to checkbox.
* Initial work on infinite scroll * Cleaned up codebase * Updated docs * Linted file. * Moved to dependencies. * Removed nestedList argument. * Added check for header. * Removed eslint disable, added more semantic html. * Added styles. * Improved docs. * Removed nestedList examples. * Added enableInfiniteScroll to List. * Toggle infinite scroll. * Fixed docgen. * Fixed tests. * Added users util. * Changed defaultProp. * Changed prop docs. * Reverted changes. * Fixed linting. * Removed function. * Use lodash map. * Fixed getStyles. * Use lodash instead. * Fixed test * Fixed scrolling issue * Fixed tests.
* Removed locale and format for DateSeparator. * Added moment dependencies to docs. * Adjusted docs to comply with new DateSeparator component. * DocGen. * Removed all date-fns functions from DateSeparator docs page. * Adjusted docs example for correct use of DateSeparator. * Removed date-fns dependency in docs. * Fixed linting error. * Adjusted DateSeparator test. * Removed date format and locale from Message component. * Removed date-fns dependency. Fixes #1036. * Split message shape to separate props. * Removed redundant props from message components. * Fixed docs pages. * DocGen. * Adjusted username prop from string to node.
…sted Message component, adjusted DateSeparator component and removed date-fns dependency.
larstadema
approved these changes
Jan 26, 2018
Codecov Report
@@ Coverage Diff @@
## master #1039 +/- ##
==========================================
+ Coverage 99.35% 99.36% +<.01%
==========================================
Files 132 131 -1
Lines 936 942 +6
==========================================
+ Hits 930 936 +6
Misses 6 6
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.