Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "deprecated" for jshint #397

Merged
merged 4 commits into from
Jun 18, 2020
Merged

Conversation

AristoChen
Copy link
Collaborator

I found the latest commit of this repo was about a month ago, so I guess that should be considerd as still maintaining?

@mre
Copy link
Member

mre commented Jun 15, 2020

There is a longer discussion here about the reasons.
I think deprecated is not the correct term here. As you point out, the tool is still receiving updates. I'm rather looking for a term to express "not recommended for new projects by the community". Maybe we could use discussion and link to the discussion issue? Opinions?

@AristoChen
Copy link
Collaborator Author

Wow, I didn't realize that there was a long discussion about deprecated.

I agree that deprecated may not be a proper term in this case, maybe discussion would be a relatively proper term.

In my opinion, maybe we can modify the definition of deprecated? maybe use this term to indicate that a repo meets the following criteria

  • Repo was not maintained for longer than half a year
  • Repo was archived
  • etc

And discussion may be used to indicate that a repo is not recommended by the community, and we can link to the discussion issue.

@mre
Copy link
Member

mre commented Jun 16, 2020

Good points.
Would you mind adding a discussion field (similar to to the source field) to both the Rust rendering code and the tools.yml? Similar to this commit: 2df2790 (Please ignore the changes in tools.yml. I went on a rampage there and fixed some inaccuracies.)
The deprecated field can stay, but I'd add the discussion links in the next step where needed.

Thanks for your ongoing support @AristoChen. Much appreciated!

@AristoChen
Copy link
Collaborator Author

I added discussion field, if there is anything that I did wrong or anthing else you want me to do, please let me know :)

@mre
Copy link
Member

mre commented Jun 18, 2020

Thanks!
We should make it clear that there was a debate from the rendered README.md.
I wonder if we can have an :information_source: (ℹ️) button next to the entry that links to the discussion.
Would you be able to add that?

@AristoChen
Copy link
Collaborator Author

AristoChen commented Jun 18, 2020

Added, does that meet your expectation?

@mre
Copy link
Member

mre commented Jun 18, 2020

Perfect! Thanks so much @AristoChen. You rock! 🎸

@mre mre merged commit 10ea6e2 into analysis-tools-dev:master Jun 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants