Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vite-plugin-nitro): pass public output path to sitemap builder #601

Merged
merged 1 commit into from
Aug 10, 2023

Conversation

brandonroberts
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

Which package are you modifying?

  • vite-plugin-angular
  • vite-plugin-nitro
  • astro-angular
  • create-analog
  • router
  • platform
  • content
  • nx-plugin
  • trpc

What is the current behavior?

When building the sitemap, the output directory uses a standard path. This would fail on Vercel as it outputs to a top-level directory.

Closes #

What is the new behavior?

When building the sitemap, the output directory uses public output path.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

[optional] What gif best describes this PR or how it makes you feel?

@netlify
Copy link

netlify bot commented Aug 10, 2023

Deploy Preview for analog-docs ready!

Name Link
🔨 Latest commit 8189251
🔍 Latest deploy log https://app.netlify.com/sites/analog-docs/deploys/64d52207cd3cd40008e10ceb
😎 Deploy Preview https://deploy-preview-601--analog-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Aug 10, 2023

Deploy Preview for analog-blog ready!

Name Link
🔨 Latest commit 8189251
🔍 Latest deploy log https://app.netlify.com/sites/analog-blog/deploys/64d52207bca6d1000802a417
😎 Deploy Preview https://deploy-preview-601--analog-blog.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Aug 10, 2023

Deploy Preview for analog-app ready!

Name Link
🔨 Latest commit 8189251
🔍 Latest deploy log https://app.netlify.com/sites/analog-app/deploys/64d5220790dc08000839749f
😎 Deploy Preview https://deploy-preview-601--analog-app.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@brandonroberts brandonroberts merged commit 94e7568 into main Aug 10, 2023
19 checks passed
@brandonroberts brandonroberts deleted the fix-sitemap-output branch August 10, 2023 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant