feat(nx-plugin): initial commit page generator/schematic #577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for analog-blog ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for analog-app ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for analog-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
brandonroberts
requested changes
Jul 28, 2023
brandonroberts
approved these changes
Jul 31, 2023
|
should i complete this one with the blog and post generators? or should we merge it like this and continue in a different complementary feature @brandonroberts |
|
@luishcastroc let's merge this as-is and do the blog support separately. Also need to add some docs for using the generators/schematics |
|
Got it let me work on that and finish those with documentation so we can have everything in place |
Villanuevand
pushed a commit
to Villanuevand/analog
that referenced
this pull request
Sep 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
Which package are you modifying?
What is the current behavior?
There are no generators for Analog plugin
Closes #565
What is the new behavior?
This feature would add the ability to generate pages. It would support Nx Generators and Angular CLI schematics.
Some examples
ng g page about -> src/app/pages/about.page.ts
ng g page blog/post -> src/app/pages/blog/post.page.ts
ng g page products/[products] -> src/app/pages/products/[products].page.ts
Does this PR introduce a breaking change?
Other information
[optional] What gif best describes this PR or how it makes you feel?