Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vite-plugin-angular): cache already resolved style and template URLs #566

Merged
merged 1 commit into from
Jul 25, 2023
Merged

fix(vite-plugin-angular): cache already resolved style and template URLs #566

merged 1 commit into from
Jul 25, 2023

Conversation

arturovt
Copy link
Contributor

No description provided.

@netlify
Copy link

netlify bot commented Jul 24, 2023

Deploy Preview for analog-app ready!

Name Link
🔨 Latest commit 6428c29
🔍 Latest deploy log https://app.netlify.com/sites/analog-app/deploys/64bef0e9cd763e00071ad14a
😎 Deploy Preview https://deploy-preview-566--analog-app.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Jul 24, 2023

Deploy Preview for analog-docs ready!

Name Link
🔨 Latest commit 6428c29
🔍 Latest deploy log https://app.netlify.com/sites/analog-docs/deploys/64bef0e99d296e000856d8fa
😎 Deploy Preview https://deploy-preview-566--analog-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Jul 24, 2023

Deploy Preview for analog-blog ready!

Name Link
🔨 Latest commit 6428c29
🔍 Latest deploy log https://app.netlify.com/sites/analog-blog/deploys/64bef0ea65230c000863283b
😎 Deploy Preview https://deploy-preview-566--analog-blog.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@brandonroberts brandonroberts added question Further information is requested blocked Blocked labels Jul 25, 2023
@brandonroberts
Copy link
Member

Thanks @arturovt. I'm not sure how much we gain here as we're already reading from the transformed source, and not reading again from the filesystem to parse the external styles and templates.

@arturovt
Copy link
Contributor Author

@brandonroberts aren't we running path.dirname and path.resolve when resolving the absolute file path?

@brandonroberts
Copy link
Member

@arturovt that's true. I didn't treat those as filesystem read/write calls but resolve does use the process.cwd()

@brandonroberts brandonroberts removed the blocked Blocked label Jul 25, 2023
@brandonroberts brandonroberts merged commit b5b6d69 into analogjs:main Jul 25, 2023
19 checks passed
@arturovt arturovt deleted the fix/resolvers-cache branch July 25, 2023 13:29
@arturovt
Copy link
Contributor Author

I’ll make those checks a bit smarter, instead of checking if the code has changed or not, the code actually may change, but not template URLs. I will extract template URL out of the code and check if it’s changed or not.

Villanuevand pushed a commit to Villanuevand/analog that referenced this pull request Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants