-
-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(vite-plugin-angular): cache already resolved style and template URLs #566
Conversation
✅ Deploy Preview for analog-app ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for analog-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for analog-blog ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Thanks @arturovt. I'm not sure how much we gain here as we're already reading from the transformed source, and not reading again from the filesystem to parse the external styles and templates. |
@brandonroberts aren't we running |
@arturovt that's true. I didn't treat those as filesystem read/write calls but resolve does use the |
I’ll make those checks a bit smarter, instead of checking if the code has changed or not, the code actually may change, but not template URLs. I will extract template URL out of the code and check if it’s changed or not. |
No description provided.