Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(router): add guide for route groups and pathless layouts #551

Conversation

markostanimirovic
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

Which package are you modifying?

  • vite-plugin-angular
  • vite-plugin-nitro
  • astro-angular
  • create-analog
  • router
  • platform
  • content
  • nx-plugin
  • trpc

What is the current behavior?

Closes #449

Does this PR introduce a breaking change?

  • Yes
  • No

@netlify
Copy link

netlify bot commented Jul 21, 2023

Deploy Preview for analog-blog ready!

Name Link
🔨 Latest commit 8ebd0c1
🔍 Latest deploy log https://app.netlify.com/sites/analog-blog/deploys/64ba9cf4ff14ac0008275de7
😎 Deploy Preview https://deploy-preview-551--analog-blog.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Jul 21, 2023

Deploy Preview for analog-docs ready!

Name Link
🔨 Latest commit 8ebd0c1
🔍 Latest deploy log https://app.netlify.com/sites/analog-docs/deploys/64ba9cf4f92aae000812a83e
😎 Deploy Preview https://deploy-preview-551--analog-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Jul 21, 2023

Deploy Preview for analog-app ready!

Name Link
🔨 Latest commit 8ebd0c1
🔍 Latest deploy log https://app.netlify.com/sites/analog-app/deploys/64ba9cf4e08a730008f42ac7
😎 Deploy Preview https://deploy-preview-551--analog-app.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.


The parameter for the route is extracted from the route path.
Dynamic routes are defined by using the filename as the route path enclosed in square brackets. The parameter for the route is extracted from the route path.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Dynamic routes are defined by using the filename as the route path enclosed in square brackets. The parameter for the route is extracted from the route path.
Dynamic routes are also defined by their filename in which we enclose the route parameter in square brackets. The parameter for the route is extracted from the route path.

This phrasing is a little confusing. The example makes very clear how it works though, so just a nitpick

@brandonroberts brandonroberts merged commit 3e3fa53 into analogjs:main Jul 21, 2023
19 checks passed
Villanuevand pushed a commit to Villanuevand/analog that referenced this pull request Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add documentation for route groups and pathless layouts
3 participants