fix(nx-plugin): cleanup styles, minor naming inconsistency, add missing await #549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for analog-blog ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for analog-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for analog-app ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
…ng await this makes the templates look almost identical regardless of using tw or not. it cleans up a minor naming inconsistency where note was named as title instead. it removes unused imports from the basic counter component. also adds a missing await in the generator
goetzrobin
force-pushed
the
cleanup-nx-plugin
branch
from
f8008b9
to
8089539
Compare
brandonroberts
approved these changes
Jul 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this makes the templates look almost identical regardless of using tw or not. it cleans up a minor naming inconsistency where note was named as title instead. it removes unused imports from the basic counter component. also adds a missing await in the generator
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
Which package are you modifying?
What is the current behavior?
Significant difference in the way tailwind and css templates look. Inconsistent naming for tRPC example
Closes #
What is the new behavior?
tailwind and css examples look the same. Naming is fixed
Does this PR introduce a breaking change?
Other information
[optional] What gif best describes this PR or how it makes you feel?