Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(create-analog): adding an option to select the ui framework #546

Closed
wants to merge 2 commits into from

Conversation

cskiwi
Copy link
Contributor

@cskiwi cskiwi commented Jul 13, 2023

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

Which package are you modifying?

  • vite-plugin-angular
  • vite-plugin-nitro
  • astro-angular
  • create-analog
  • router
  • platform
  • content
  • nx-plugin
  • trpc

What is the current behavior?

the option --skipTailwind has been changed with an --ui option that allows the selection of the UI framework the developer wants to use

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

existing commands using the --skipTailwind won't work anymore

Other information

[optional] What gif best describes this PR or how it makes you feel?

@netlify
Copy link

netlify bot commented Jul 13, 2023

Deploy Preview for analog-docs ready!

Name Link
🔨 Latest commit f0bedd7
🔍 Latest deploy log https://app.netlify.com/sites/analog-docs/deploys/64b0022306431600086c7645
😎 Deploy Preview https://deploy-preview-546--analog-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Jul 13, 2023

Deploy Preview for analog-blog ready!

Name Link
🔨 Latest commit f0bedd7
🔍 Latest deploy log https://app.netlify.com/sites/analog-blog/deploys/64b00223e98ef80008b05765
😎 Deploy Preview https://deploy-preview-546--analog-blog.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Jul 13, 2023

Deploy Preview for analog-app ready!

Name Link
🔨 Latest commit f0bedd7
🔍 Latest deploy log https://app.netlify.com/sites/analog-app/deploys/64b00223a4738600085dcd3f
😎 Deploy Preview https://deploy-preview-546--analog-app.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@brandonroberts
Copy link
Member

Thanks @cskiwi. I need to think about this more. Not certain we should go down this route though with so many options out there. Today, it's Material and Tailwind. Tomorrow it's Material, Tailwind, Taiga UI, Bootstrap, Clarity, etc. We want to keep create-analog minimal and leave it up to the developer to tailor it further. I also don't see Tailwind/Material as mutually exclusive.

I could see the CLI go in the direction of picking what type of app you'd like to build.

  • Blog
  • Todos (Fullstack Example)
  • Barebones

We also have #517 which would change the work being done here also.

@cskiwi
Copy link
Contributor Author

cskiwi commented Jul 18, 2023

@brandonroberts Sounds like a good direction to navigate to.

I've added the material stuff mostly because that's mostly what I've been using for the last 8-ish years. So creating new projects directly with Material included would save me some time.

Of course if it was fully integrated it with nx, then we would only have to validate that the normal way of adding angular material to a nx app works, and we'd be golden

@goetzrobin
Copy link
Member

@brandonroberts seems like what you are describing is along the lines of this effort, too:
#413

Are you suggesting we'd continue to ask for tailwind like we currently do and then ask for the type of application?

@brandonroberts
Copy link
Member

@goetzrobin yes, I think the type of app you want to build and using Tailwind are two separate questions. Asking what type of app will generate a starter app from a template we have.

@goetzrobin
Copy link
Member

Awesome! I like that approach a lot!

@cskiwi cskiwi closed this Aug 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants