-
-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(create-analog): adding an option to select the ui framework #546
Conversation
✅ Deploy Preview for analog-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for analog-blog ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for analog-app ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Thanks @cskiwi. I need to think about this more. Not certain we should go down this route though with so many options out there. Today, it's Material and Tailwind. Tomorrow it's Material, Tailwind, Taiga UI, Bootstrap, Clarity, etc. We want to keep I could see the CLI go in the direction of picking what type of app you'd like to build.
We also have #517 which would change the work being done here also. |
@brandonroberts Sounds like a good direction to navigate to. I've added the material stuff mostly because that's mostly what I've been using for the last 8-ish years. So creating new projects directly with Material included would save me some time. Of course if it was fully integrated it with nx, then we would only have to validate that the normal way of adding angular material to a nx app works, and we'd be golden |
@brandonroberts seems like what you are describing is along the lines of this effort, too: Are you suggesting we'd continue to ask for tailwind like we currently do and then ask for the type of application? |
@goetzrobin yes, I think the type of app you want to build and using Tailwind are two separate questions. Asking what type of app will generate a starter app from a template we have. |
Awesome! I like that approach a lot! |
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
Which package are you modifying?
What is the current behavior?
the option
--skipTailwind
has been changed with an--ui
option that allows the selection of the UI framework the developer wants to useWhat is the new behavior?
Does this PR introduce a breaking change?
existing commands using the
--skipTailwind
won't work anymoreOther information
[optional] What gif best describes this PR or how it makes you feel?