-
-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add Vercel deploypent provider info #545
Conversation
✅ Deploy Preview for analog-blog ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for analog-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for analog-app ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Did you not have to adjust the Build & Output settings for it to work for you? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do believe we should add a section about the potential changes you need to make on Vercel side if you are using an Nx repo and/or there is no npm build
command defined in your package.json.
@goetzrobin good point. I've created 3 repo's containing the 3 possible combinations.
It seems that you just have to add the the default project to make the builds work, so this might be something to include into the generator? I've update the instructions to include the info on how to do this or define a project to build. Luckily you can do all the changes in your project. It is possible to do them on vercel.com, but they allow it to be configured via the |
Looks good to me! @cskiwi unit tests seem to be failing for some reason outside of your scope (since it's only doc changes 🤔) Thank you! |
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
Which package are you modifying?
What is the current behavior?
Closes #493
What is the new behavior?
Does this PR introduce a breaking change?
Other information
[optional] What gif best describes this PR or how it makes you feel?