Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add Vercel deploypent provider info #545

Merged
merged 4 commits into from
Jul 17, 2023

Conversation

cskiwi
Copy link
Contributor

@cskiwi cskiwi commented Jul 13, 2023

remake of #544 because of branching issues on my side

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

Which package are you modifying?

  • vite-plugin-angular
  • vite-plugin-nitro
  • astro-angular
  • create-analog
  • router
  • platform
  • content
  • nx-plugin
  • trpc

What is the current behavior?

Closes #493

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

[optional] What gif best describes this PR or how it makes you feel?

@netlify
Copy link

netlify bot commented Jul 13, 2023

Deploy Preview for analog-blog ready!

Name Link
🔨 Latest commit 18c88f5
🔍 Latest deploy log https://app.netlify.com/sites/analog-blog/deploys/64b3a610efba310008fa9be1
😎 Deploy Preview https://deploy-preview-545--analog-blog.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Jul 13, 2023

Deploy Preview for analog-docs ready!

Name Link
🔨 Latest commit 18c88f5
🔍 Latest deploy log https://app.netlify.com/sites/analog-docs/deploys/64b3a61022dde80007d91c71
😎 Deploy Preview https://deploy-preview-545--analog-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Jul 13, 2023

Deploy Preview for analog-app ready!

Name Link
🔨 Latest commit 18c88f5
🔍 Latest deploy log https://app.netlify.com/sites/analog-app/deploys/64b3a610481b1500083af40d
😎 Deploy Preview https://deploy-preview-545--analog-app.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@goetzrobin
Copy link
Member

Did you not have to adjust the Build & Output settings for it to work for you?
My Vercel project uses yarn & nx and I had to manually set my build command.
I just want to confirm 👍 thanks for adding this!

Copy link
Member

@goetzrobin goetzrobin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do believe we should add a section about the potential changes you need to make on Vercel side if you are using an Nx repo and/or there is no npm build command defined in your package.json.

@cskiwi
Copy link
Contributor Author

cskiwi commented Jul 16, 2023

@goetzrobin good point.

I've created 3 repo's containing the 3 possible combinations.

It seems that you just have to add the the default project to make the builds work, so this might be something to include into the generator?

I've update the instructions to include the info on how to do this or define a project to build.

Luckily you can do all the changes in your project. It is possible to do them on vercel.com, but they allow it to be configured via the vercel.json file. Which I think is better because it skips manual steps when the project is cloned/re-created/generated/...

@goetzrobin
Copy link
Member

Looks good to me! @cskiwi unit tests seem to be failing for some reason outside of your scope (since it's only doc changes 🤔) Thank you!

@brandonroberts brandonroberts merged commit d2eb634 into analogjs:main Jul 17, 2023
18 of 19 checks passed
@cskiwi cskiwi deleted the docs/vercel-provider branch July 17, 2023 14:42
Villanuevand pushed a commit to Villanuevand/analog that referenced this pull request Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs: add deployment guide for Vercel
3 participants