Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(content): add support for front-matter in routes using markdown … #205

Merged

Conversation

goetzrobin
Copy link
Member

Add support for front-matter in routes that
use markdown files by first passing the content
passed to the MarkdownContentRenderer through
front-matter to extract any possible attributes.

Closes #198

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe: Added test config for content package

Which package are you modifying?

  • vite-angular-plugin
  • astro-angular
  • create-analog
  • router
  • platform
  • content

What is the current behavior?

Issue Number: #198

What is the new behavior?

Frontmatter content is not displayed in markdown routes anymore.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@netlify
Copy link

netlify bot commented Jan 11, 2023

Deploy Preview for analog-app ready!

Name Link
🔨 Latest commit 32ebdb5
🔍 Latest deploy log https://app.netlify.com/sites/analog-app/deploys/63beef8a5459ea0008be6090
😎 Deploy Preview https://deploy-preview-205--analog-app.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Jan 11, 2023

Deploy Preview for analog-docs ready!

Name Link
🔨 Latest commit 32ebdb5
🔍 Latest deploy log https://app.netlify.com/sites/analog-docs/deploys/63beef8a9df9750008fd0ff7
😎 Deploy Preview https://deploy-preview-205--analog-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

…files

Add support for front-matter in routes that
use markdown files by first passing the content
passed to the MarkdownContentRenderer through
front-matter to extract any possible attributes.

Closes analogjs#198
@goetzrobin goetzrobin force-pushed the add-front-matter-to-content-renderer branch from d5fe342 to 32ebdb5 Compare January 11, 2023 17:19
Copy link
Member

@brandonroberts brandonroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@brandonroberts brandonroberts merged commit 5b4292a into analogjs:main Jan 11, 2023
@brandonroberts
Copy link
Member

Awesome, thanks! @allcontributors add @goetzrobin for code

@allcontributors
Copy link
Contributor

@brandonroberts

I've put up a pull request to add @goetzrobin! 🎉

@goetzrobin goetzrobin deleted the add-front-matter-to-content-renderer branch January 18, 2023 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: add support for frontmatter in routes that use markdown files
2 participants