Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vite-plugin-angular): set ngDevMode in during build optimization #1417

Merged
merged 1 commit into from
Oct 24, 2024

Conversation

brandonroberts
Copy link
Member

PR Checklist

Closes #

What is the new behavior?

ngDevMode is applied to the define object so dev-mode only code is tree-shaken in production

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

[optional] What gif best describes this PR or how it makes you feel?

Copy link

netlify bot commented Oct 24, 2024

Deploy Preview for analog-app ready!

Name Link
🔨 Latest commit aeabe3d
🔍 Latest deploy log https://app.netlify.com/sites/analog-app/deploys/671a8ee60bb58d000862f3a9
😎 Deploy Preview https://deploy-preview-1417--analog-app.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Oct 24, 2024

Deploy Preview for analog-docs ready!

Name Link
🔨 Latest commit aeabe3d
🔍 Latest deploy log https://app.netlify.com/sites/analog-docs/deploys/671a8ee6f6a4a500086b5588
😎 Deploy Preview https://deploy-preview-1417--analog-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Oct 24, 2024

Deploy Preview for analog-blog ready!

Name Link
🔨 Latest commit aeabe3d
🔍 Latest deploy log https://app.netlify.com/sites/analog-blog/deploys/671a8ee612e0100008541623
😎 Deploy Preview https://deploy-preview-1417--analog-blog.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Oct 24, 2024

Deploy Preview for analog-ng-app ready!

Name Link
🔨 Latest commit aeabe3d
🔍 Latest deploy log https://app.netlify.com/sites/analog-ng-app/deploys/671a8ee7f390640008f08c5d
😎 Deploy Preview https://deploy-preview-1417--analog-ng-app.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@brandonroberts brandonroberts merged commit 8e1a3b4 into beta Oct 24, 2024
24 checks passed
@brandonroberts brandonroberts deleted the fix-ngdevmode branch October 24, 2024 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant