Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vite-plugin-angular): force rebuild and analysis on file changes #1416

Merged
merged 1 commit into from
Oct 24, 2024

Conversation

brandonroberts
Copy link
Member

PR Checklist

Fixes #1394
Fixes #1345

What is the new behavior?

In some cases, when adding or renaming page route files, the dev server had to be restarted, along with hard refreshing the browser for the changes to be picked up.

This fix forces a rebuild/re-analysis of the Angular compilation with the newly added/renamed files, so renaming a page route file is picked up and refreshed correctly without restarting.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

[optional] What gif best describes this PR or how it makes you feel?

Copy link

netlify bot commented Oct 24, 2024

Deploy Preview for analog-app ready!

Name Link
🔨 Latest commit e968744
🔍 Latest deploy log https://app.netlify.com/sites/analog-app/deploys/6719cd17d4c876000857eeb1
😎 Deploy Preview https://deploy-preview-1416--analog-app.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Oct 24, 2024

Deploy Preview for analog-docs ready!

Name Link
🔨 Latest commit e968744
🔍 Latest deploy log https://app.netlify.com/sites/analog-docs/deploys/6719cd172648fc0008075a84
😎 Deploy Preview https://deploy-preview-1416--analog-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Oct 24, 2024

Deploy Preview for analog-blog ready!

Name Link
🔨 Latest commit e968744
🔍 Latest deploy log https://app.netlify.com/sites/analog-blog/deploys/6719cd1777ffa60008fbe0c6
😎 Deploy Preview https://deploy-preview-1416--analog-blog.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Oct 24, 2024

Deploy Preview for analog-ng-app ready!

Name Link
🔨 Latest commit e968744
🔍 Latest deploy log https://app.netlify.com/sites/analog-ng-app/deploys/6719cd17ea50d4000957a6b4
😎 Deploy Preview https://deploy-preview-1416--analog-ng-app.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@brandonroberts brandonroberts merged commit 94e7da1 into beta Oct 24, 2024
23 of 24 checks passed
@brandonroberts brandonroberts deleted the fix-file-change-rebuild branch October 24, 2024 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

need to kill cli each time creating a new page or folder
1 participant