Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(router): inject HttpClient only when page endpoint is configured #1412

Merged
merged 1 commit into from
Oct 18, 2024

Conversation

brandonroberts
Copy link
Member

PR Checklist

Closes #

What is the new behavior?

HttpClient is not injected if page endpoints are not configured

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

[optional] What gif best describes this PR or how it makes you feel?

Copy link

netlify bot commented Oct 18, 2024

Deploy Preview for analog-docs ready!

Name Link
🔨 Latest commit f9d2546
🔍 Latest deploy log https://app.netlify.com/sites/analog-docs/deploys/67123690580d5b0008e1cfb2
😎 Deploy Preview https://deploy-preview-1412--analog-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Oct 18, 2024

Deploy Preview for analog-blog ready!

Name Link
🔨 Latest commit f9d2546
🔍 Latest deploy log https://app.netlify.com/sites/analog-blog/deploys/67123690cf87890008dacfbc
😎 Deploy Preview https://deploy-preview-1412--analog-blog.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Oct 18, 2024

Deploy Preview for analog-app ready!

Name Link
🔨 Latest commit f9d2546
🔍 Latest deploy log https://app.netlify.com/sites/analog-app/deploys/67123690f84d9000073bd8b4
😎 Deploy Preview https://deploy-preview-1412--analog-app.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Oct 18, 2024

Deploy Preview for analog-ng-app ready!

Name Link
🔨 Latest commit f9d2546
🔍 Latest deploy log https://app.netlify.com/sites/analog-ng-app/deploys/6712369003cb9c000841b2a0
😎 Deploy Preview https://deploy-preview-1412--analog-ng-app.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@brandonroberts brandonroberts merged commit c037b01 into beta Oct 18, 2024
20 of 24 checks passed
@brandonroberts brandonroberts deleted the fix-router-http branch October 18, 2024 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant