Backends API rework #1059
Merged
Backends API rework #1059
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This array contains data known at compile-time and is never updated later; so it can be const. Signed-off-by: Paul Cercueil <[email protected]>
We only need to print it once; and it makes more sense to print it at the "debug" log level. Signed-off-by: Paul Cercueil <[email protected]>
They previously would only work with the backends provided by Libiio, either built-in or modules, enabled at compilation time. This meant that third-party modules were not listed in there, while official modules were. Change these functions so that they only work for built-in backends, and rename them to iio_get_builtin_backends_count() and iio_get_builtin_backend(). Signed-off-by: Paul Cercueil <[email protected]>
If the backend name cannot be found in the list of built-in backends, check if a module exists for it. Since the loading of a dynamic backend might print errors (e.g. if the file is unrecognized), the iio_has_backend() function now accepts an extra "params" argument. Signed-off-by: Paul Cercueil <[email protected]>
Update to the new prototype of iio_has_backend(), and use the new functions iio_get_builtin_backends_count() and iio_get_builtin_backend(). Signed-off-by: Paul Cercueil <[email protected]>
Use the new functions iio_get_builtin_backends_count() and iio_get_builtin_backend(). Signed-off-by: Paul Cercueil <[email protected]>
mhennerich
approved these changes
Oct 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the backends API functions to better separate between built-in backends, and the ones loaded from external modules.