Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade pion/webrtc to v4 #985

Merged
merged 1 commit into from
Oct 14, 2024
Merged

Upgrade pion/webrtc to v4 #985

merged 1 commit into from
Oct 14, 2024

Conversation

marcovidonis
Copy link
Collaborator

pion/webrtc/v4 got out of beta and was officially released last week. Looking at the breaking changes in the release notes, I don't think there should be impacts on this project. All tests pass when I run them locally.

In #983 we decided to keep a separate branch for v4. I thought I'd also open a PR for it since it's no longer in beta. Are there any other checks that we could do so when know when we're ready to merge?

@anacrolix
Copy link
Owner

No, if you're happy with it and it passed your checks that should be good!

@anacrolix anacrolix merged commit 05ab0ca into master Oct 14, 2024
18 checks passed
@anacrolix
Copy link
Owner

anacrolix commented Oct 14, 2024

There is a performance issue that might be worth revisiting that exists because of a WebRTC workaround: #982 (comment). I don't know if you think this might fix it, and want to try pion/v4 without that workaround and see if we can remove it?

Edit: Fixed brainfarts above.

@marcovidonis
Copy link
Collaborator Author

I don't know if v4 will fix it, but it's worth a try! I'll give it a look

Ns2Kracy pushed a commit to Ns2Kracy/torrent that referenced this pull request Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants