Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to now run Tests in Parallel #961

Closed
wants to merge 7 commits into from
Closed

Conversation

gillianyost
Copy link

Now no longer need --runInBand for tests

While using this repo for a flaky test detection project, I have found that when your tests are run in parallel they have test dependencies which creates flaky tests. I have modified the test dependencies between test suites where the regular clearing of the tests/__output directory means the test suites cannot be run in parallel. Running in parallel is more efficient and thus in the package.json file the "--runInBand" command has been removed from the test command. There are now separate config files for the tests and the helper function that clears the output now takes a parameter to select which directory it clears.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jorenbroekema
Copy link
Collaborator

In v4 branch we use web test runner which runs each test file in a separate browser tab, number depends on concurrency.

Node tests were migrated to mocha, not currently in parallel due to some issues with Mocha's ESM support, but either way I think we can close this PR since we moved away from Jest, I explained some of that here #1113 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants