chore(example): removing example lock files #861
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giovannimartusciello
pushed a commit
to giovannimartusciello/style-dictionary
that referenced
this pull request
Sep 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes: After talking to some devs, I don't believe our examples need lock files. Plus, some examples didn't have them already, some did, and one or two had a yarn.lock file in there. Lock files in examples are unnecessary because real users probably won't use those lock files anyways and get different transitive dependencies. A better mechanism would be to either run canary builds that do a full npm/yarn install without a lock file so they get the latest dependencies within the semver range and make sure those apps build. Or running that as integration tests for PRs in Github actions.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.