Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Yaml Example #84

Closed
wants to merge 3 commits into from
Closed

Adding Yaml Example #84

wants to merge 3 commits into from

Conversation

dbanksdesign
Copy link
Member

Issue #, if available: #19

Description of changes: Adding an example showing how to use Yaml instead of JSON.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@davixyz
Copy link
Contributor

davixyz commented Apr 26, 2018

👍

@chazzmoney
Copy link
Collaborator

Hmmm. This leads me into a question whether supporting a different properties format should be more pluggable? We added in #89 as supported functionality instead of an example. Do we need consistency for properties?

@dbanksdesign
Copy link
Member Author

Yea after #89 gets implemented, this example will not be relevant. We can probably scrap this PR and do a new example after #89.

@dbanksdesign dbanksdesign deleted the yaml branch November 13, 2018 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants