Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(references): Tokens with a number value should be interpolated correctly #825

Merged
merged 7 commits into from
Jun 2, 2022

Conversation

jakobe
Copy link
Contributor

@jakobe jakobe commented May 25, 2022

Issue #, if available:
Fixes #696

Description of changes:
This PR fixes an issue with tokens referencing another token with a number value type inside a string value with surrounding text being wrongly resolved to/replaced by to the referenced number value. See #696 for further details.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link
Collaborator

@chazzmoney chazzmoney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Numbers aren't interpolated
3 participants