-
Notifications
You must be signed in to change notification settings - Fork 567
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(formats): Add outputReferences
support to scss/map-deep
#720
feat(formats): Add outputReferences
support to scss/map-deep
#720
Conversation
Use the `formattedVariables` within the `scss/map-deep` formatter to add support for the `outputReferences` option. Closes: amzn#712 A side effect of this change is that `scss/map-deep` also supports the `themeable` token property. For backward compatibility changes have been made so tokens default to being themeable with `scss/map-deep`, unlike for `scss/variables` where tokens are not themeable by default. See amzn#474
I'm using an internal |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is great! Just 2 minor comments about the themeable_default
and snapshots and I think we are good!
An option to add/remove the `!default` flag on Sass variables by default. This may be overridden by setting a `themeable` attribute in a token's definition. Defaults to `true` for backward compatibility. Unlike the `scss/variables` which does not output Sass variables with the `!default` flag by default.
- remove trailing new line - add leading new line
Whether or not to add the `!default` flag on Sass variables by default. This may be overridden by setting a `themeable` attribute in a token's definition. Matches the `themeable` option of the `scss/map-deep` format but defaults to `false`, retaining its existing behaviour.
seems kebab case is used more than camel case
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for making those changes!
Use the
formattedVariables
function within thescss/map-deep
formatterto add support for the
outputReferences
option.Related issue: #712
before:
after:
A side effect of this change is that
scss/map-deep
alsosupports the
themeable
token property. For backward compatibilitychanges have been made so tokens default to being themeable
with
scss/map-deep
, unlike forscss/variables
where tokensare not themeable by default. See #474
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.