Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(lib): Fix createFormatArgs positional args #655

Merged
merged 1 commit into from
Jun 25, 2021
Merged

fix(lib): Fix createFormatArgs positional args #655

merged 1 commit into from
Jun 25, 2021

Conversation

kylegach
Copy link
Contributor

@kylegach kylegach commented Jun 22, 2021 •
edited
Loading

Issue #, if available: #652

Description of changes:

  • Update createFormatArgs to return allTokens and tokens properties along with properties and allProperties
  • Update snapshots
    • It's hard to confirm in the diff, but I manually confirmed that the newly-added values for allTokens are the same as allProperties, and tokens are the same as properties

Note:

Correcting the types will be done in a future PR.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

chazzmoney
chazzmoney approved these changes Jun 25, 2021
View reviewed changes
Copy link
Collaborator

@chazzmoney chazzmoney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this - this is how we should have done it. Double thanks for understanding our intent and fixing it to work that way!

LGTM! :shipit:

dbanksdesign
dbanksdesign approved these changes Jun 25, 2021
View reviewed changes
Copy link
Member

@dbanksdesign dbanksdesign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :shipit:

@dbanksdesign dbanksdesign merged commit 29e511d into amzn:main Jun 25, 2021
@kylegach kylegach deleted the fix-dict-positional-arg branch June 26, 2021 02:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chazzmoney chazzmoney chazzmoney approved these changes

@dbanksdesign dbanksdesign dbanksdesign approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kylegach @dbanksdesign @chazzmoney