feat(format): use named parameters in formatter functions #533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbanksdesign
changed the title
|
This looks good to me. If this wasn't you, I'd require a third party to write up some documentation on this before we would merge it. So... can you add some documentation? 😁 |
|
LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes: Changed the method signature of the formatter function so that it can used named parameters rather than positional. This is done by overloading the first argument that is passed to the formatter function, so that users don't have to update their custom format code if they don't want to. This also fixes a lot of eslint errors.
TODO:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.