bugfix: fix conditional to ensure we catch properties with a falsy value #423
Conversation
__tests__/__output/json-nested.json
Outdated
| { | ||
| "color": { | ||
| "base": { | ||
| "red": { | ||
| "primary": "#611D1C", | ||
| "secondary": { | ||
| "inverse": "#000000" | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
I'm not sure where this came from... Is this ok @dbanksdesign ?
There was a problem hiding this comment.
I think there might be a race condition in our unit tests somewhere.. there shouldn't be anything checked into tests/__output/ that is the folder where we put files generated by the unit tests. It should get cleared after tests run. You can remove this file or just try running the tests again and see if it gets removed.
__tests__/__output/json-nested.json
Outdated
| { | ||
| "color": { | ||
| "base": { | ||
| "red": { | ||
| "primary": "#611D1C", | ||
| "secondary": { | ||
| "inverse": "#000000" | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
I think there might be a race condition in our unit tests somewhere.. there shouldn't be anything checked into tests/__output/ that is the folder where we put files generated by the unit tests. It should get cleared after tests run. You can remove this file or just try running the tests again and see if it gets removed.
Fixes #406