Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(format): add info about filtering and format configuration #312

Merged
merged 2 commits into from
Aug 14, 2019

Conversation

dbanksdesign
Copy link
Member

Issue #, if available: #303 #297

Description of changes: Adding documentation in the Formats section around using filters and format configuration.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@@ -31,10 +31,57 @@ You use formats in your config file under platforms > [platform] > files > [file

There is an extensive (but not exhaustive) list of [included formats](#pre-defined-formats) available in Style Dictionary.

### Format configuration

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was just to comment and say this is a great new feature, then looked at my code and fount I am already doing this. 🙈

@@ -27,10 +27,57 @@ You use formats in your config file under platforms > [platform] > files > [file

There is an extensive (but not exhaustive) list of [included formats](#pre-defined-formats) available in Style Dictionary.

### Format configuration

Formats are can take configuration to make them more flexible. This allows you to re-use the same format multiple times with different configuration or to allow the format to use data not defined in the tokens themselves. To configure a format add extra attributes on the file object in your configuration like so:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Formats are can take configuration

docs/formats.md Outdated
@@ -31,10 +31,57 @@ You use formats in your config file under platforms > [platform] > files > [file

There is an extensive (but not exhaustive) list of [included formats](#pre-defined-formats) available in Style Dictionary.

### Format configuration

Formats are can take configuration to make them more flexible. This allows you to re-use the same format multiple times with different configuration or to allow the format to use data not defined in the tokens themselves. To configure a format add extra attributes on the file object in your configuration like so:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Formats are can take configuration

@chazzmoney
Copy link
Collaborator

:shipit:

@chazzmoney chazzmoney merged commit e660cb8 into master Aug 14, 2019
@chazzmoney chazzmoney deleted the fix-303-297 branch August 14, 2019 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants