Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(error-messaging): problems when a transform does not exist #264

Merged
merged 2 commits into from
Apr 23, 2019

Conversation

chazzmoney
Copy link
Collaborator

If a transform does not exist, then the current code will fail with an error of "Unable to find property 'matcher' of undefined". This is not clear to the user, so I tried to make clear what is going on.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link
Member

@dbanksdesign dbanksdesign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than removing the __output, this is good to go

@@ -0,0 +1,12 @@
{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests/__output/ should not be committed to git, it is only for generating output files that should then be cleaned up in the tests. I pulled this branch down locally and run tests and it cleared that directory, so you should be able to re-run the tests to delete this file.

Copy link
Member

@dbanksdesign dbanksdesign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :shipit:

@dbanksdesign dbanksdesign merged commit d5c0583 into master Apr 23, 2019
@dbanksdesign dbanksdesign deleted the transform-error-message branch April 23, 2019 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants