Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(config): use config.js if config.json is not found; updated docs #249

Merged
merged 1 commit into from
Feb 19, 2019

Conversation

chazzmoney
Copy link
Collaborator

feat(config): use config.js if config.json is not found; updating documentation

Added functionality to search / use 'config.js' in root if 'config.json' is not found in root.
Modified documentation to ensure clarity around using JS based config with the CLI.

fix: #238
docs: #238
replaces #247 to be based on master branch instead of develop

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@chazzmoney
Copy link
Collaborator Author

Let me know if I did the Conventional Commits specification accurately - tried to follow it.

Copy link
Member

@dbanksdesign dbanksdesign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :shipit:

@chazzmoney chazzmoney merged commit 01cd0b7 into master Feb 19, 2019
@chazzmoney chazzmoney deleted the fix-docs-and-feat-configjs branch February 19, 2019 20:49
dbanksdesign pushed a commit that referenced this pull request Feb 19, 2019
Added functionality to search / use 'config.js' in root if 'config.json' is not found in root.
Modified documentation to ensure clarity around using JS based config with the CLI.

fix: #238
docs: #238
replaces #247 to be from master branch instead of develop
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unclear doc about javascript configuration with CLI tool
2 participants