Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

moved the snapshot tests for the “all” formats to its own declaration #223

Merged
merged 1 commit into from
Jan 2, 2019
Merged

moved the snapshot tests for the “all” formats to its own declaration #223

merged 1 commit into from
Jan 2, 2019

Conversation

didoo
Copy link
Contributor

@didoo didoo commented Dec 24, 2018

Issue #, if available:

Description of changes:
In #125 I added the snapshot testing for the "formats/all" in the function that was testing a return of a string. For clarity is better to have the snapshot test with its own specific declaration.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link
Member

@dbanksdesign dbanksdesign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :shipit:

@dbanksdesign dbanksdesign merged commit 14e4b0f into amzn:develop Jan 2, 2019
@didoo didoo deleted the fix_split_snapshot_test branch January 19, 2019 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants