Add a "Create React App" example #211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
examples/advanced/create-react-app/src/style-dictionary-dist/variables.js
Outdated
Show resolved
Hide resolved
…/start of CRA + removed the generated files from the repo
|
@dbanksdesign replied to all your comments and pushed a couple of changes. still have to write the Readme, be patient with me :) |
didoo
changed the title
|
@dbanksdesign added the Readme, now it can be pulled if you think is OK. |
|
LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
As discussed previously, I have added a Create React App example, with three different components styled in three different ways (all of them consuming design tokens generated by SD):
I still have to write a proper Readme.md so please wait, don't merge. In the meantime any feedback is welcome :)
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.